tnajdek / zotero-api-client / 24465130677

100%

push

github

Fixed multiple edge-case bugs + minor optimization

- Fixed `makeUrlQuery` dropping falsy query param values like `0` and `false`
- Fixed file upload register request (stage 3) firing even when the storage upload (stage 2) failed
- Fixed `processOpts` (`apiScheme`/`apiPath` normalization) not being called for requests other than GET
- Fixed missing URL-encoding the filename in the file upload form body
- Fixed `getLinks()` and `getMeta()` throwing `TypeError` when response data is null or a non-object
- Fixed file upload ignoring user-provided `mtime`, always overwriting it with `Date.now()`
- Fixed `url.replace('\n', '')` only removing the first newline when parsing file URL responses
- Fixed `RelLinks` TypeScript type using `previous` instead of the correct `prev`, and added missing `first`
- Removed redundant double `Array.from()` in `getRelLinks()`
- Optimised file upload body construction by using `TextEncoder`
- Removed redundant `this.message = message` in `ErrorResponse` constructor since `super(message)` already sets it

364 of 365 branches covered (99.73%)

Branch coverage included in aggregate %.

49 of 49 new or added lines in 3 files covered. (100.0%)

1701 of 1701 relevant lines covered (100.0%)

29.99 hits per line