cybertec-postgresql / pgcov / 24460361700

47%

push

github

fix(instrument): place signal before terminal stmts inside branches

When a segment wraps a terminal statement (RETURN, RAISE EXCEPTION)
inside a control-flow keyword (IF/ELSIF/ELSE … THEN … RETURN …), the
coverage signal was placed after the entire segment — past the RETURN —
making it unreachable. Coverage for these branches was always reported
as 0 regardless of test execution.

Add findTerminalPos() to scan a segment for an embedded terminal
statement and return its byte offset. In emitSegment, use a three-way
dispatch:

  1. Segment starts with terminal → signal before (existing logic)
  2. Segment contains terminal inside → signal before the inner
     terminal (new logic)
  3. No terminal → signal after (existing logic)

This ensures every injected PERFORM pg_notify() is reachable by at
least one execution path.

Add indentOf() helper to extract indentation for the inner terminal
line (may differ from the segment's first-line indent).

Add tests: TestFindTerminalPos (8 cases),
TestInstrumentBody_ReturnInBranches,
TestInstrumentBody_RaiseExceptionInBranch, and
TestInstrumentBody_MixedTerminalNonTerminalBranches.

43 of 45 new or added lines in 1 file covered. (95.56%)

1004 of 2516 relevant lines covered (39.9%)

0.45 hits per line