prebid / Prebid.js / 24458762341

96%

push

github

Smartx Bid Adapter: fix outstream renderer tests and wire adUnitCode (#14727)

The three oustreamRender tests in smartxBidAdapter_spec.js currently fail
against master with 'Cannot read properties of undefined (reading find)'
thrown from isRendererPreferredFromAdUnit in src/Renderer.js. The adapter
tests import the module directly without running a full pbjs init, so
pbjs.adUnits is undefined and the .find() call in that core function
throws as soon as bid.renderer.render() runs in the describe block. The
second and third tests then cascade with 'Attempted to wrap
getElementById which is already wrapped' because the first test throws
before its sinon stub is restored.

Seed pbjs.adUnits = [] in a before() hook at the top of the spec so the
core lookup has an iterable to traverse. This is the same workaround
showheroes-bsBidAdapter_spec.js already ships (with the same inline
comment about the Renderer.js call path), so it is a known-good pattern
for this class of outstream adapter tests.

While here, pass the bid request's adUnitCode into Renderer.install so
that in a real auction a publisher can override the smartx-supplied
renderer via their adUnit renderer configuration. The adapter was
previously constructing the renderer with no adUnitCode at all, which
meant isRendererPreferredFromAdUnit always matched against nothing and
publisher overrides were silently ignored. Same pattern as
showheroes-bsBidAdapter.js.

No functional change when the adUnitCode is absent (current test fixture
shape); the new argument is an additive option on Renderer.install.

42965 of 52887 branches covered (81.24%)

2 of 2 new or added lines in 1 file covered. (100.0%)

219440 of 227711 relevant lines covered (96.37%)

72.73 hits per line