stacklok / toolhive / 24455351406

66%

Build Type

push

github

Committed by web-flow

Commit Message

Remove config.groupRef fallback and external_auth_config_ref enum (#4834)

* Remove config.groupRef fallback and external_auth_config_ref enum

Remove the deprecated config.groupRef fallback from ResolveGroupName()
and Validate() on VirtualMCPServer. The converter now explicitly sets
config.Group from spec.groupRef so downstream runtime code still works.

Remove the deprecated DeprecatedBackendAuthTypeExternalAuthConfigRef
constant ("external_auth_config_ref") from the kubebuilder enum, the
converter's deprecation handling, and the Validate() switch case.

Update all test fixtures to use spec.GroupRef instead of Config.Group.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate CRD manifests and API docs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Update Config.Group comment to reflect current usage

The field is no longer deprecated — it is actively used by the
standalone CLI and populated by the operator converter from
spec.groupRef.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add GroupRef to E2E test fixtures

The E2E tests were creating VirtualMCPServer objects with only
Config.Group and no spec.groupRef, causing validation failures
now that the config.groupRef fallback is removed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review findings: require GroupRef, add Validate test, clean fixtures

Make GroupRef +kubebuilder:validation:Required on VirtualMCPServer (F6),
matching the IncomingAuth pattern. The API server now rejects resources
missing groupRef at admission time.

Add TestVirtualMCPServer_Validate_RequiresGroupRef covering nil and
empty-name rejection paths (F2).

Fix stale DefaultValues and NamespaceIsolation fixtures to use GroupRef
instead of Config.Group (F4).

Remove redundant Config.Group from all controller test fixtures that
already have GroupRef, and replace direct Spec.Config.Group reads with
ResolveGroupN... (continued)

Coverage Stats

9 of 9 new or added lines in 2 files covered. (100.0%)

7 existing lines in 3 files now uncovered.

57418 of 87278 relevant lines covered (65.79%)

61.39 hits per line