dcdpr / jp / 24452243916

67%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(cli, conversation): Overhaul conversation targeting system (#557)

To start, here is the new targeting help text, that explains it all:

```
Conversation Targeting

Use a conversation ID (e.g. jp-c17761673600), a keyword, or any text to
fuzzy-search by title.

Interactive Filter/Picker:
  ?                             # select from all
  ?p, ?pinned                   # select from pinned
  ?s, ?session                  # select from session

Conversation Aliases:
  l, latest                     # target latest active in workspace
  n, newest                     # target newest created
  p, pinned                     # target latest pinned
  s, session                    # target previous active in session

Multi-Target Keywords:
  +p, +pinned                   # target all pinned
  +s, +session                  # target all activated in session
```

This information can be gotten either via `--id=help`, `jp conversation
use help`, or `--help` on any command that takes a conversation target,
either as a positional argument or as a flag.

Additionally, pinned conversations now track their pin time, allowing
cross-pinned conversations to be sorted by pin time. This sorting is
applied both in `jp conversation ls` and interactive target pickers.

---

As for the internals, here is what changed:

Replace the `pinned: bool` field on `Conversation` with `pinned_at:
Option<DateTime<Utc>>`, recording when a conversation was pinned. This
enables ordering pinned conversations by pin time rather than treating
them all as equivalent. A new `is_pinned()` helper is provided for
callers that only need the boolean.

The `ConversationTarget` enum is redesigned around clearer semantics:

- `LastActivated` → `Latest` (`l`, `latest`)
- `LastCreated` → `Newest` (`n`, `newest`)
- `Previous` → `SessionPrevious` (`s`, `session`)
- `Current` is removed
- `LatestPinned` added (`p`, `pinned`) — resolves the most recently
pinned conversation
- `Pinned` added (`+p`, `+pinn... (continued)

Coverage Stats

97 of 286 new or added lines in 15 files covered. (33.92%)

384 existing lines in 9 files now uncovered.

22055 of 34793 relevant lines covered (63.39%)

262.64 hits per line