kubeflow / sdk / 24450547545
85%

DEFAULT BRANCH: main
Ran
Jobs 2
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.85% (+0.1%) from 79.71%
24450547545

push

github

web-flow 
fix(trainer): validate polling_interval is strictly less than timeout (#402)

* fix(trainer): validate polling_interval is strictly less than timeout

In wait_for_job_status(), the guard used strict greater-than (>),
allowing polling_interval == timeout to pass validation. This results
in round(timeout/polling_interval) == 1, meaning the job is polled
exactly once with no retry window — silently wrong behavior that
contradicts the documented constraint 'must be less than timeout'.

Fix: change > to >= in the validation guard.

Fixes #400

Signed-off-by: Prabinder Singh <prabindersinghh@gmail.com>

* fix(trainer): address review comments on polling_interval validation

- Add guard for zero/negative polling_interval to prevent ZeroDivisionError
  at round(timeout / polling_interval); raise ValueError with clear message
- Improve ValueError message for polling_interval >= timeout to include
  actual parameter values for easier debugging
- Replace hardcoded "basic-job" string with BASIC_TRAIN_JOB_NAME constant
  in the new test case to match existing conventions
- Add test cases for zero and negative polling_interval values

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Prabinder Singh <prabindersinghh@gmail.com>

* fix(trainer): extend polling_interval validation to all backends

Apply same polling_interval validation to localprocess and optimizer
backends as requested in PR review.

- Add polling_interval <= 0 guard to prevent ZeroDivisionError
- Change > to >= so equal values are also rejected (strictly less than)
- Improve ValueError messages to include actual parameter values
- Add parametrized test cases for all three validation scenarios
  (greater than, equal to, zero, negative) in both backend test files

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Prabinder Singh <prabindersinghh@gmail.com>

---------

Signed-off-by: Prabinder Singh <prabindersinghh@gmail.com>
Co-authored-by: Claude Sonnet ... (continued)

4581 of 5737 relevant lines covered (79.85%)

1.6 hits per line

Coverage Regressions

Lines Coverage ∆ File
61
35.44
 2.59% kubeflow/optimizer/backends/kubernetes/backend.py
27
79.81
 0.13% kubeflow/trainer/backends/kubernetes/backend.py
8
82.03
 1.87% kubeflow/trainer/backends/localprocess/backend.py
1
97.62
 -0.02% kubeflow/trainer/backends/localprocess/backend_test.py
Jobs
ID Job ID Ran Files Coverage
1 python-3.11 - 24450547545.1 87
79.85
 GitHub Action Run
2 python-3.10 - 24450547545.2 87
79.85
 GitHub Action Run
Source Files on build 24450547545