stacklok / toolhive / 24442318933

66%

Build Type

push

github

Committed by web-flow

Commit Message

Add horizontal scaling tests for vmcp (#4724)

* Revert "Revert "Add LRU capacity to ValidatingCache, remove sentinel pattern, add storage Update" (#4730)"

This reverts commit acc1f6630.

* changes from review

* Add horizontal scaling tests for vmcp

Add integration and e2e tests for Redis-backed vMCP session sharing

Integration tests (pkg/vmcp/server/sessionmanager, miniredis):
- AC1: cross-pod session reconstruction via RestoreSession on cache miss
- AC2: hijack prevention — wrong/nil callers rejected after restore,
       correct caller routes successfully
- AC4: all backends unreachable on restore → empty routing table returned
- AC5: NotifyBackendExpired removes backend from Redis metadata;
       subsequent restore on a fresh pod skips the expired backend
- AC6: LocalSessionDataStorage (no Redis) → no cross-pod sharing

E2E tests (test/e2e/thv-operator/virtualmcp, Kind + real Redis):
- replicas=2 + Redis → SessionStorageWarning=False and Ready=True
- cross-pod session reconstruction: session initialized on pod A is
  usable on pod B via transport.WithSession(sessionID)

Note: AC3 (LRU eviction, RC-10) is intentionally excluded — TTL-based
Redis eviction is sufficient.

Closes #4222

* changes from review

* fixes from review

---------

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Coverage Stats

41 of 61 new or added lines in 7 files covered. (67.21%)

1036 existing lines in 15 files now uncovered.

57280 of 87200 relevant lines covered (65.69%)

62.33 hits per line