umputun / ralphex / 24441321342

83%

Build Type

push

github

Committed by web-flow

Commit Message

Skip post-codex claude review when no findings (#282)

* feat: skip post-codex claude review when external review found no issues

The post-codex claude review loop exists to catch regressions from fixes
applied during the external review phase. When the external review found
no actionable issues (CodexDone on first iteration, empty output, or
tool disabled), no fixes were made and there is nothing to regress —
running the review is wasted time and tokens.

runExternalReviewLoop now returns (bool, error) where the bool indicates
whether findings were found. runCodexAndPostReview uses this to skip the
post-codex review when unnecessary.

* fix: improve comment accuracy and test naming per copilot review

- fix misleading comment on runExternalReviewLoop return value to describe
  actual mechanism (CodexDone signal check) instead of approximation
- rename test subcase to clarify intent

* fix: clarify test name - no actionable findings, not dismissal

Coverage Stats

19 of 26 new or added lines in 1 file covered. (73.08%)

2 existing lines in 1 file now uncovered.

6390 of 7810 relevant lines covered (81.82%)

207.99 hits per line