umputun / revdiff / 24440661846

90%

Build Type

push

github

Committed by web-flow

Commit Message

Structural refactor: split main.go, theme boundary cleanup, UI state consolidation (#107)

* chore: add .pi/ to gitignore

* add plan: structural-refactor

* feat: split app/main.go into focused startup concern files

Decompose the 783-line app/main.go monolith into 5 focused files:
- config.go: options struct, parseArgs, config path helpers
- stdin.go: stdin validation, TTY reopen, stdin renderer prep
- renderer_setup.go: VCS detection, git/hg/no-VCS renderer wiring
- themes.go: theme commands, color mapping, apply/collect helpers
- history_save.go: review session auto-save logic

main.go is now a thin entrypoint (229 LOC) with main() and run().
Tests split to match: config_test.go, stdin_test.go,
renderer_setup_test.go, themes_test.go.

* feat: introduce UI-side ThemeCatalog dependency interface

Add ThemeCatalog interface, ThemeEntry, and ThemeSpec types to app/ui/model.go
as the consumer-side contract for theme discovery and persistence. Add concrete
Catalog type to app/theme backed by existing ListOrdered/Load functions. Wire
through package main via thin themeCatalog adapter that composes theme catalog
with config-file persistence. Existing direct theme loading in app/ui stays
until Tasks 4-5 migrate callers to the new interface.

* feat: introduce loadedFileState struct and migrate all callers

Replace 13 scattered top-level Model fields (currFile, diffLines,
highlightedLines, intraRanges, fileAdds, fileRemoves, blameData,
blameAuthorLen, lineNumWidth, singleColLineNum, loadSeq, mdTOC,
singleFile) with a single loadedFileState struct accessed as m.file.

This makes the parallel-array synchronization invariant explicit and
groups all per-file state into one coherent object. All callers across
app/ui/*.go are updated to use the new m.file.xxx access pattern.

* feat: group modelConfigState and layoutState sub-structs in ui.Model

* feat: restructure app/theme package — zero standalone functions, Catalog-centric API

All standalone functions in ap... (continued)

Coverage Stats

1224 of 1463 new or added lines in 24 files covered. (83.66%)

9 existing lines in 5 files now uncovered.

6594 of 7409 relevant lines covered (89.0%)

351.12 hits per line