KarpelesLab / libwallet / 24432220077

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

Sec-ClientId header for Crypto/WalletSign calls

The WalletSign backend identifies which wallet app a request came from
via the Sec-ClientId HTTP header — used to pick branded SMS / email
copy, apply per-app rate limits, and tag audit logs. libwallet had no
way to send it; every wallet embedding libwallet looked identical.

Added WalletInfo in wltwallet/clientid.go (ClientID + future Name +
Version fields) stored in a package atomic. withClientID(ctx) returns
a context whose Value(*http.Request) stamps Sec-ClientId onto the
request — the rest library calls that hook just before dispatching
(rest@v0.6.17 rest.go:165 `ctx.Value(r)`). Every Crypto/WalletSign:*
call site in remote.go + walletkey.go now wraps its context through
withClientID.

Endpoint: Info:setWalletInfo (generic so we can add more metadata
fields later without a new endpoint) + Info:getWalletInfo. Host calls
once at startup; no-op before that and no header is sent.

Dart:
- client.info.setWalletInfo(clientId:, name?, version?) — required
  clientId, optional name/version
- client.info.getWalletInfo() returns a typed WalletInfo
- WalletInfo exported from the barrel

No behavior change when the host doesn't call setWalletInfo — the
header just isn't sent, same as before.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

17 of 47 new or added lines in 4 files covered. (36.17%)

1 existing line in 1 file now uncovered.

2109 of 9522 relevant lines covered (22.15%)

2.66 hits per line