zhouqingqing / qpmodel / 24424533381

90%

push

github

Fix OR handling in inToMarkJoin and scalarToSingleJoin (issue #271)

Previously only existsToMarkJoin handled OR expressions correctly.
When a correlated IN subquery or scalar subquery appeared inside an
OR expression (e.g., "a1 IN (select ...) OR a2 > 1"), the
decorrelation would not properly preserve OR semantics.

Apply the same OR-aware filter extraction pattern from
existsToMarkJoin to both inToMarkJoin (via extractCurINExprFromNodeAFilter)
and scalarToSingleJoin (via djoinOnRightFilter):
- Detect OR conjuncts containing extra subqueries
- Set canReplace flag so the caller advances innerNode correctly
- Preserve OR expressions for further unnesting

Note: the nested case where OR appears *inside* a scalar subquery's
filter alongside another correlated subquery (the original issue #271
example) remains unsupported during unnesting and falls back to
nested-loop execution.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

4796 of 5663 branches covered (84.69%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

11416 of 12358 relevant lines covered (92.38%)

2769364.17 hits per line