KarpelesLab / libwallet / 24418628689

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

mpurse_signMessage: Bitcoin-family message signing via TSS

Full wiring of mpurse_signMessage for Monacoin (and any configured
bitcoin-family chain):

- New `Account.SignBitcoinMessage(prefix, message, opts)` and
  `Account.SignCompact(hash, headerOffset, opts)` helpers in
  wltacct/btc_sign.go. They run the Go TSS signer, parse the DER
  output, brute-force the recovery ID against the known pubkey, and
  emit Bitcoin Core's 65-byte compact signature (header=v+31 for
  compressed-pubkey P2PKH/P2WPKH + R + S).

- `BitcoinMessagePrefix(chainId)` returns the per-chain magic bytes
  including the length byte: \x18Bitcoin... / \x19Monacoin... /
  \x19Litecoin... / \x19Dogecoin... / \x18Bitcoin... (BCH uses
  Bitcoin's prefix by convention).

- Web3:request routes mpurse_signMessage through a new
  "mpurse_sign_message" request type (stored with account ID so the
  approve handler can find the account across network switches;
  bitcoin-family addresses reformat per current network).

- Approval handler signs with SignBitcoinMessage, returns the
  signature as a base64 string.

- Monacoin address derivation (bech32 mona1...) added to
  bitcoinAddress — previously default'd to an error.

Dart:
- New `MpurseSignMessageRequest` subtype in the sealed PendingRequest
  hierarchy. Exposes `message` text and `signature` (base64) getters.
- `RequestApi.approve` now accepts `keys:` for signing approvals.

Tests:
- Go unit tests cover the prefix table, varint, and a full sign +
  RecoverCompact round trip against a known pubkey (no TSS needed).
- Dart integration test creates a Monacoin network, bitcoin-family
  account, connects, fires mpurse_signMessage, and verifies the
  payload reaches MpurseSignMessageRequest correctly.

mpurse_signRawTransaction / sendRawTransaction / sendAsset still
return "not implemented" — TX parsing / UTXO mapping is a separate
milestone.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

28 of 125 new or added lines in 4 files covered. (22.4%)

1 existing line in 1 file now uncovered.

1962 of 7841 relevant lines covered (25.02%)

3.18 hits per line