JayBizzle / Crawler-Detect / #1974

100%

push

Fix bugs and harden tests (patch-safe) (#595)

* Improve code quality: fix bugs, add type safety, and harden tests

- Fix null concatenation deprecation in setUserAgent (PHP 8.1+)
- Fix MSIE exclusion pattern missing * quantifier
- Reset matches at top of isCrawler() for reliable state
- Add preg error handling in isCrawler()
- Make compileRegex() protected (internal API)
- Add return type declarations to all methods
- Add parameter type hints throughout
- Use setUp() in tests, fix property visibility/naming
- Fix typo in test method name (persit -> persist)
- Optimize collision test from O(n²) to O(n²/2)
- Add tests for regex validity and stored agent immutability

* Revert BC-breaking type hints and visibility change

Keeps the bug fixes and deprecation fix in isCrawler()/setUserAgent()
and the MSIE exclusion pattern fix, but drops the param/return type
declarations and the compileRegex() visibility change so this can ship
as a patch release.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add test for preg_match error branch in isCrawler()

Forces preg_match to return PREG_BACKTRACK_LIMIT_ERROR by setting
pcre.backtrack_limit to 1, covering the previously untested error path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

12 of 12 new or added lines in 1 file covered. (100.0%)

40 of 40 relevant lines covered (100.0%)

14.03 hits per line