KarpelesLab / libwallet / 24416091053

25%

push

github

typed pending-request flow (sealed subtypes + full-payload event)

Go: the `request` event now carries the full request object, not just
its id. Consumers can render the approval prompt on first paint without
a follow-up `Request/<id>` round-trip.

Dart: `PendingRequest` is sealed with one subtype per Web3 request kind —
ConnectRequest, SignRequest, PersonalSignRequest, SignTypedDataRequest,
AddNetworkRequest, ChangeNetworkRequest, WatchAssetRequest,
SolanaSignMessage/Transaction/SignAndSendTransactionRequest, and
UnknownPendingRequest for forward-compat. Each subtype exposes typed
accessors (message bytes, typed-data map, typed network descriptor,
transaction bytes, etc.) instead of dumping into a `dynamic` blob.

Dart: new `client.pendingRequests` stream yields fully-parsed
PendingRequest values directly. Consumers can pattern-match:

    client.pendingRequests.listen((req) async {
      switch (req) {
        case ConnectRequest():
          if (await showConnectSheet(req.host)) {
            await client.requests.approve(req.id, accounts: [acct.id]);
          } else {
            await client.requests.reject(req.id);
          }
        case PersonalSignRequest():
          ok(await showSignSheet(req.messageAsText ?? 'binary'))
              ? await client.requests.approve(req.id)
              : await client.requests.reject(req.id);
        default:
          await client.requests.reject(req.id);
      }
    });

The raw `requestEvents` stream still works (the typed `request` getter
on RequestEvent is null if the backend pre-dates this change).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

0 of 8 new or added lines in 1 file covered. (0.0%)

1910 of 7643 relevant lines covered (24.99%)

3.25 hits per line