Ouranosinc / xsdba / 24413724925

79%

Build Type

push

github

Committed by web-flow

Commit Message

Fix local arg issue in properties (#267)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #266
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [ ] CHANGELOG.rst has been updated (with summary of main changes).
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?
The issue is about variable scope and probably linked to the multiple
layers of wrapping, including `map_groups`. The fix is to declare all
variables needed in the actual function in its signature, so they are
carried in the wraps as values.

### Does this PR introduce a breaking change?


### Other information:

Coverage Stats

19 of 20 new or added lines in 1 file covered. (95.0%)

1 existing line in 1 file now uncovered.

2838 of 3600 relevant lines covered (78.83%)

6.16 hits per line