KarpelesLab / libwallet / 24411017299

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

add direct account-signing endpoints + account/wallet validation

New endpoints (bypass Web3 approval flow for wallet hosts):
- Account/<id>:signMessage (solana | evm/personal_sign | raw modes)
- Account/<id>:signTransaction (Solana)
- Account/<id>:signAndSendTransaction (Solana, broadcasts via current net)

These let the wallet host sign directly without routing through
pending-request/approve, removing ~80 lines of async listener code
and the main correctness risk in the Dart backend.

Validation gaps fixed:
- Wallet.Curve must be "secp256k1", "ed25519", or empty (defaults to
  secp256k1). Previously typos silently became secp256k1.
- CreateAccount now rejects type/curve mismatches: solana requires
  ed25519, ethereum/bitcoin require secp256k1.
- Account path is now correct per type: bitcoin → m/44/0/0/i
  (BIP-44 coin_type 0) instead of the ETH coin_type. ed25519 accounts
  get Path="m" since SLIP-10 hardened derivation isn't possible over
  TSS public keys — the path was cosmetic anyway.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 208 new or added lines in 5 files covered. (0.0%)

1 existing line in 1 file now uncovered.

1878 of 7532 relevant lines covered (24.93%)

3.13 hits per line