FlexMeasures / flexmeasures / 24408980112

81%

push

github

Fix: scheduling none soc mixed assets (#2108)

* fix: skip SoC preference for non-storage devices

Context:
- PR #2023 introduced a StockCommitment that assumes each preferred device has soc_max and soc_at_start.
- Mixed-device schedules can include non-storage devices such as PV, which do not have state-of-charge values.
Change:
- Guard the full-SoC preference so it only applies when both soc_max and soc_at_start are defined.
- Prevent mixed-device scheduling from crashing on NoneType subtraction.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* test: cover mixed storage and non-storage scheduling

Context:
- The scheduler regression was exposed by HEMS-style mixed-device flex-models that combine storage with PV.
Change:
- Add a regression test covering a mixed battery plus PV schedule.
- Verify scheduling computes without applying SoC-only preferences to the PV device.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* docs: add changelog entry for mixed-device scheduling fix

Context:
- PR #2108 fixes a mixed-device scheduling regression in StorageScheduler.
Change:
- Document the fix in the unreleased v0.32.0 bugfixes section.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* docs: move the changelog entry for an unreleased regression

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: fixture create the wrong asset type

Signed-off-by: F.N. Claessen <claessen@seita.nl>

---------

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Co-authored-by: F.N. Claessen <claessen@seita.nl>

1 of 1 new or added line in 1 file covered. (100.0%)

12037 of 15164 relevant lines covered (79.38%)

0.79 hits per line