agama-project / agama / 24408334262

push

github

refactor(web): network connection form UX (bonus part) (#3367)

# TL;DR

This bonus PR for the network connection form series includes polish
improvements and bug fixes.

The IP configuration modes have been restructured: the "unset" mode
(undefined method) has been replaced with "auto" (method.auto) as the
new default, and all modes have been renamed for clarity. Additional,
Manual mode now requires both addresses and gateway (gateway was
optional before).

The PR also fixes a bug where IP addresses, DNS servers, and search
domains appeared duplicated when editing saved connections, caused by
merging config and system arrays without deduplication. Additional
improvements include better connection name generation, proper IP mode
inference when editing connections, comprehensive translator comments
across all files, and code cleanup.

---

## The original description

A bonus PR for the network connection revamp series for addressing few
minor things found while reviewing notes.

### Minor Cleanup

Removes unnecessary props and type casts.

### Add missing translator comments

All touched and new files in this series has been reviewed for adding
missing `// TRANSLATORS:` comments. These provide translators with
context for format strings, abbreviations, UI roles, and otherwise
ambiguous strings.
### Introduce a new `Interpolate` component.

A utility component for rendering translated strings that include a
single placeholder, allowing arbitrary React content to be inserted via
a render prop.

#### Purpose

Some translated sentences need to include React elements (like links,
buttons, or styled text). While it's possible to manually split strings
or build sentences in fragments (the scattered approach across the
codebase), it makes translations harder to maintain and future updates
more error-prone. Thus, this small component:

*   Centralizes the pattern in a reusable component.
*   Prevents accidental fragmented translation units.
*   Makes future im... (continued)

3558 of 5536 branches covered (64.27%)

Branch coverage included in aggregate %.

92 of 97 new or added lines in 8 files covered. (94.85%)

21301 of 26349 relevant lines covered (80.84%)

90.14 hits per line