24405289100
66%
master: 66%

Ran 14 Apr 2026 02:43PM UTC

Jobs 1

Files 95

Run time 1min

Badge

Embed ▾

Committed 14 Apr 2026 02:39PM UTC coverage: 66.276%. Remained the same

Build # 24405289100

Build Type

Pull #723

github

Committed by

ptondereau

Commit Message

fix: inject #[link] attributes correctly when rustfmt is unavailable

When rustfmt is not installed for the active Rust toolchain, bindgen
emits the entire bindings file as a single line (~120K characters).
The previous line-by-line matching approach would place the #[link]
attribute on a separate line before that mega-line, where it attached
to the first item (a struct) instead of the extern blocks. This left
all PHP/Zend symbols (std_object_handlers, zend_ce_*, etc.) without
a link directive, causing "undefined symbol" errors at link time.

Replace line-by-line iteration with direct string replacement using a
three-phase marker approach:

1. Insert a placeholder before every `extern "C/fastcall" {`
2. Swap `unsafe <marker>` to `<marker> unsafe` so the attribute
   lands before the full `unsafe extern` block
3. Expand markers into the real `#[link(name = "php8")]` attribute

This works identically on both formatted (multi-line) and unformatted
(single-line) bindgen output.

Tested on Windows 11 with nightly rust-lld, PHP 8.2 NTS, and rustfmt
deliberately removed to reproduce CI conditions.

Pull Request Pull Request #723: fix: inject #[link] attributes correctly when rustfmt is unavailable

Coverage Stats

8417 of 12700 relevant lines covered (66.28%)

33.43 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	24405289100.1	14 Apr 2026 02:43PM UTC	95	66.28	GitHub Action Run

extphprs / ext-php-rs / 24405289100
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 24405289100

extphprs / ext-php-rs / 24405289100 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 24405289100

extphprs / ext-php-rs / 24405289100
66%
master: 66%

README BADGES
x