decentraland / comms-gatekeeper / 24400258316

Pull #249

github

fix: address PR review findings for bot-presenter-handler

- Fix preview place detection using livekit.isLocalPreview instead of broken string matching
- Set canUpdateOwnMetadata: false for watcher credentials to prevent role spoofing
- Guard getPresenters JSON.parse with try/catch for malformed metadata
- Move NotSceneAdminError from 401 to 403 (authorization, not authentication)
- Skip unnecessary writes in removeFromRoomMetadataArray when nothing changed
- Replace unsafe `as PlaceAttributes` cast with narrow StreamAccessPlace type
- Add null guards before room_id! non-null assertions
- Use randomUUID() instead of Date.now() for identity generation to prevent collisions

981 of 1328 branches covered (73.87%)

Branch coverage included in aggregate %.

189 of 233 new or added lines in 16 files covered. (81.12%)

2803 of 3279 relevant lines covered (85.48%)

41.61 hits per line