MerginMaps / server / 24395881105

93%

master: 92%

Build Type

Pull #610

github

Committed by varmar05

Commit Message

Rework concurrent upload using upsert strategy

Replace the old try/except IntegrityError + cleanup loop pattern with an atomic upsert in Upload.create_upload().
Decouple the upload directory name from the DB primary key via transaction_id. Upload directory is created at this stage, no need to take care for it later.

With the upsert logic, the ObjectDeletedError scenario which happened because a concurrent request could delete a stale upload row mid-operation is eliminated:
  - During push_finish, the heartbeat context manager continuously updates last_ping, keeping the upload fresh
  throughout the operation
  - A concurrent request can only take over an upload whose last_ping has expired
  - Since heartbeat prevents expiry, no other request can claim the row while push_finish is running
  - The upload object therefore stays valid for the full lifetime of the request — ObjectDeletedError becomes
  impossible

Pull Request Pull Request #610: rework concurrent upload

Coverage Stats

156 of 165 new or added lines in 8 files covered. (94.55%)

7 existing lines in 3 files now uncovered.

9114 of 9779 relevant lines covered (93.2%)

0.93 hits per line