KarpelesLab / gofreetype / 24380230612

61%

push

github

Fix every staticcheck finding; wire staticcheck into CI

Sweep across the whole tree to silence staticcheck:

- ST1005 (capitalized error strings): cff/cff.go's wrapped errors now
  use lowercase "name INDEX", "top DICT", "private DICT", etc.
- U1000 (unused code):
  * cff/charstring.go: subrFrame struct (code + pc fields never read)
    replaced by a maxSubrDepth constant; the [10]subrFrame array was
    there only for its length.
  * cff/index.go: local u32 helper removed (cff package already has
    one in dict.go).
  * raster/geom.go: pRot135CW / pRot135CCW helpers removed — never
    referenced.
  * shape/shape.go: gdefOf accessor dropped; it wasn't reachable.
  * truetype/face.go: glyphCacheEntry struct removed — left over
    from the pre-LRU cache.
- SA1019 (deprecated): io/ioutil -> os; image.ZP -> image.Point{} in
  truetype tests, freetype.go, freetype_test.go.
- SA4006 (values never used):
  * truetype/hint.go opMD0/opMD1: restored v as explicit var rather
    than the triple-assignment where the initial value was dead.
  * truetype/truetype.go IndexWithVariation: dropped stale j = h + 1
    write before a break.
  * truetype_test.go scaling parser: used _ where prefix / s are
    never read again.
- SA9004 (only first constant has explicit type): every NameID*
  constant now declares the type explicitly.
- type1/parse_test.go: removed the dead initial csAPlain literal and
  the unused encNum1 / encNumNeg1 helpers that were scaffolding
  artifacts from an earlier draft.

CI gains a staticcheck step so regressions surface in PRs.

go vet and go test all still pass across every package.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

3 of 14 new or added lines in 4 files covered. (21.43%)

5922 of 11055 relevant lines covered (53.57%)

1507.1 hits per line