uber / h3 / 24370537065

99%

push

github

Vec3d indexing refactor (#1145)

* Add Vec3d math functions: dot, cross, normalize, mag, distSq, latLngToVec3

From uber/h3#1052.

* Refactor faceijk.c: Vec3d as core coordinate type

Extract _vec3dToClosestFace, _vec3dToHex2d, _vec3dToFaceIjk from LatLng
wrappers. Add _vec3dAzimuthRads (3D tangent-plane azimuth) and _hex2dToVec3
(inverse via Rodrigues' rotation). Add vec3ToCell and cellToVec3 public API.

Existing LatLng API is unchanged — wrappers delegate to the new Vec3d functions.

From uber/h3#1052.

* Add Vec3d unit tests

From uber/h3#1052.

* Route latLngToCell/cellToLatLng through Vec3d; remove dead LatLng-only code

* cell boundary code to Vec3d path; remove _hex2dToGeo, _geoAzDistanceRads, and tests

* vec3ToCell validation tests

* align function names and struct: hex2d -> vec2d

* use Vec2 and Vec3 everywhere

* normalize

* h3 -> cell; years

* bench

* update bench

* correctness

* test vertices and along edges

* _vec3TangentBasis helper

* vec3LinComb helper

* return by value

* pass by value

* clean

* test for inlining

* header-only; suffering on LTO

* header only

* clean up benchmark script

* _vec3ToFaceIjk

* output params

* header version of _ijkToVec2

* revert

* revert

* redo

* inline ijk ops

* going header only

* directedEdgeToBoundary bench

* justfile

* revert coorijk header change

* comments

* update benchmarks

* again

* reduce digits on testCliEdgeLengthM

* vertexToLatLng benchmark

* cover line in latLng.c

* remove temporary benchmarks and assignment tests

* _faceIjkToCell back to _faceIjkToH3

* restore Vec3d

* missed a few

* test files

* vec2d.h

* Vec2d

* vec2 names

* more vec2 names

* names

* comments

* years

* years

* boop

* years

* old test

* haven't i done this one already?

* _hex2dToVec3

* pass output by reference

* _vec3ToHex2d

* forward declare

* comment

* bah

* bah bah

* move around _vec3ToClosestFace

* todo

* bring benchmarks back in

* nits

* pass by value

* expr... (continued)

1874 of 1899 branches covered (98.68%)

Branch coverage included in aggregate %.

92 of 92 new or added lines in 3 files covered. (100.0%)

3332 of 3351 relevant lines covered (99.43%)

34044096.02 hits per line