KarpelesLab / anyhash / 24361627390

88%

push

github

Fix xxh3/xxh128 custom secret: use d.getSecret() in all code paths

All xxh3/xxh128 code paths (Write, every short/medium/long sum path,
and the merge-accumulators functions) hardcoded the global xxh3Secret
instead of consulting d.getSecret(), which returns the user-supplied
secret when one is set via SetSecret(). This meant custom secrets had
no effect on the hash output.

Replace all 41 references to xxh3Secret[…] in method bodies with a
local sec := d.getSecret(), and thread a sec parameter through the
standalone xxh3MergeAccs64/xxh3MergeAccs64Hi helpers.

Add TestXXH3Secret with PHP-generated vectors for both xxh3 and xxh128
using a 256-byte custom secret.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

19 of 54 new or added lines in 1 file covered. (35.19%)

2927 of 3337 relevant lines covered (87.71%)

637.79 hits per line