nicklaw5 / helix / 24360260385

93%

main: 93%

push

github

fix: Return non-nil error when Twitch API responds with an error body (#259)

* Initial plan

* Return non-nil error when Twitch API responds with error body

Add ErrTwitchResponseError sentinel and pullErrorFromResponse helper to
helix.go. All endpoint methods now return a wrapped ErrTwitchResponseError
when the response body contains a non-zero error status field, making it
easier for callers to detect Twitch API errors via the standard error
interface or errors.Is.

Also reset response error fields at the start of each doRequest retry loop
so that a successful retry after a token refresh does not inherit the stale
error state from the preceding 401 response.

Update all test files to conditionally check err only for 2xx responses
or handle the new ErrTwitchResponseError for expected non-2xx responses.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: nicklaw5 <7908386+nicklaw5@users.noreply.github.com>

* Add UPGRADING.md with v3 migration guide

Agent-Logs-Url: https://github.com/nicklaw5/helix/sessions/3fcbaaf4-b4dc-40ec-9306-a88802d12d42

Co-authored-by: nicklaw5 <7908386+nicklaw5@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nicklaw5 <7908386+nicklaw5@users.noreply.github.com>

123 of 126 new or added lines in 40 files covered. (97.62%)

1866 of 2009 relevant lines covered (92.88%)

6414.56 hits per line