decentraland / archipelago-workers / 24359921743

79%

Build Type

push

github

Committed by web-flow

Commit Message

fix: ws-connector WebSocket lifecycle safety (#115)

- Route all socket close paths through safeEndWebSocket to prevent
  calling end/close on freed µWebSockets handles
- Fix peer registry leak when welcome message send fails by moving
  changeStage before the send
- Add post-auth deny list check against real address from auth chain
  to prevent bypass via claimed address
- Fix fetchDenyList retry storm on failure by updating TTL timestamp
  even on error
- Add ws.send() return value check for island change forwarding
- Fix error message in island_changed handler (was "peer_connect")
- Add onAborted handler in wrap() to prevent writing to aborted
  µWebSockets responses
- Clear pending timeout in close handler

Coverage Stats

137 of 207 branches covered (66.18%)

Branch coverage included in aggregate %.

35 of 49 new or added lines in 3 files covered. (71.43%)

2 existing lines in 1 file now uncovered.

708 of 841 relevant lines covered (84.19%)

370.6 hits per line