stacklok / toolhive / 24350821129

66%

Build Type

push

github

Committed by web-flow

Commit Message

Remove enforceServers and image validation from MCPRegistry (#4776)

* Remove enforceServers and image validation from MCPRegistry

The enforceServers feature and its image validation code have been
broken since PR #2568 removed the data sources from the operator. The
{name}-registry-storage ConfigMap that image validation reads from is
never created — nothing populates it. As a result, enforceServers has
silently done nothing: the ConfigMap lookup returns NotFound and
checkImageInRegistry returns false for every check.

Remove the entire feature rather than attempting to fix it:
- Remove EnforceServers field from MCPRegistrySpec CRD
- Remove GetStorageName() helper (dead since sources removal)
- Delete image_validation.go and its tests
- Remove image validation call sites from MCPServer and
  EmbeddingServer controllers
- Remove ConditionImageValidated and related status constants
- Remove getConfigMapName from registryapi
- Delete the enforcing example
- Regenerate CRD manifests

Fixes #4717

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove enforceServers references from documentation

Update REGISTRY.md, architecture docs, and regenerate CRD API docs
to remove all references to the removed enforceServers feature and
the stale registry-storage ConfigMap.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address PR review feedback

- Remove stale image validation troubleshooting from REGISTRY.md
- Remove stale image validation log reference from REGISTRY.md

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address PR review feedback

- Remove "Provides image validation" from README.md feature list
- Replace fictional syncStatus/apiStatus status fields in REGISTRY.md
  with actual MCPRegistryStatus fields (phase, message, url,
  readyReplicas, conditions)
- Fix stale jsonpath examples in troubleshooting section

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.c... (continued)

Coverage Stats

0 of 2 new or added lines in 1 file covered. (0.0%)

26 existing lines in 3 files now uncovered.

56838 of 86620 relevant lines covered (65.62%)

59.13 hits per line