facebookincubator / TTPForge / 24349828845

56%

main: 67%

Pull #615

github

Remove redundant validation checks

Summary:
Remove two redundant validation checks from the validate pipeline:

1. Delete `ValidateRequirements()` — it does a map→marshal→unmarshal
   round-trip into `blocks.RequirementsConfig` then calls `.Validate()`.
   This is already done by `ValidatePreamble()` which unmarshals into
   `PreambleFields` and calls `pf.Validate()` → `pf.Requirements.Validate()`.

2. Remove `steps:` from `requiredFieldPatterns` in `ValidateRequiredFields` —
   the steps boundary is already validated by `preprocess.Parse()` (called in
   `ValidatePreamble`) and `ValidateStructure()`.

Reviewed By: d0n601

Differential Revision: D100219502

29 of 46 new or added lines in 7 files covered. (63.04%)

3154 of 5668 relevant lines covered (55.65%)

14.63 hits per line