facebookincubator / TTPForge / 24349827242

56%

main: 67%

Pull #613

github

Wire up TTP-level env to inject into all steps

Summary:
The TTP struct had an `env` field (`Environment map[string]string`) that was
parsed from YAML but never actually used during execution — it was dead code.

This change wires it up so that TTP-level environment variables are injected
into every step's execution environment. The merge order is:

- Local execution: os.Environ() → TTP env → step env (last wins)
- Remote execution: TTP env → step env (no os.Environ inheritance)
- Expect steps: TTP env set first, then step env overrides

This also fixes an existing env ordering bug where step-level env vars were
prepended before os.Environ(), causing inherited vars to silently override
user-specified ones (Go's exec.Cmd.Env uses last-wins semantics).

Example usage:
```yaml
env:
  API_ENDPOINT: "https://internal.corp/api"
  TEAM: "purple"
steps:
  - name: step1
    inline: curl $API_ENDPOINT/health
  - name: step2
    inline: curl $API_ENDPOINT/execute
```

Reviewed By: d0n601

Differential Revision: D100214957

8 of 20 new or added lines in 3 files covered. (40.0%)

3150 of 5662 relevant lines covered (55.63%)

14.65 hits per line