facebookincubator / TTPForge / 24349827587

56%

main: 67%

Pull #614

github

Consolidate parseutils into canonical PreambleFields

Summary:
Add the missing `Authors []string` field to `blocks.PreambleFields` and
create `parseutils.ParsePreambleOnly()` which returns the canonical struct.
Then migrate all 4 callers of the old `parseutils.ParseTTP()` and delete
the parallel type definitions (`TTP`, `Arg`, `Mitre`, `Platform`,
`Requirements`).

This eliminates the maintenance burden of keeping two TTP preamble struct
definitions in sync. There is now a single canonical preamble type
(`blocks.PreambleFields`) used throughout the codebase.

Callers migrated:
- cmd/run.go (UUID lookup)
- cmd/enumauthors.go (author aggregation)
- cmd/enumttps.go (MITRE/platform/author filtering)
- pkg/validation/integration.go (dummy arg extraction)

Key type mappings:
- parseutils.Mitre → *blocks.MitreAttack (pointer, nil-check added)
- parseutils.Requirements → *blocks.RequirementsConfig (pointer, nil-check added)
- parseutils.Arg.Default (any) → args.Spec.Default (*string, dereference added)
- parseutils.Arg.Choices ([]any) → args.Spec.Choices ([]string)

Reviewed By: d0n601

Differential Revision: D100220109

29 of 46 new or added lines in 7 files covered. (63.04%)

3154 of 5668 relevant lines covered (55.65%)

14.63 hits per line