aws / karpenter-provider-aws / 24342323764

68%

main: 68%

Build Type

Pull #9080

github

Committed by KeitaW

Commit Message

fix: nil pointer dereference in CapacityReservationFromEC2 for Interruptible field

lo.Ternary eagerly evaluates all arguments in Go, so
lo.Ternary(cr.Interruptible == nil, false, *cr.Interruptible)
dereferences *cr.Interruptible unconditionally, panicking when
the pointer is nil. This is the default for all standard ODCRs
and capacity blocks returned by the EC2 API.

Replace with lo.FromPtrOr which safely returns the default value
when the pointer is nil.

Also adds a test case with nil Interruptible to prevent regression.

Fixes #9079

Pull Request Pull Request #9080: fix: nil pointer dereference in CapacityReservationFromEC2 for Interruptible field

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

8443 of 12467 relevant lines covered (67.72%)

0.77 hits per line