stacklok / toolhive / 24333217052
66%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 617
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.594% (+0.02%) from 65.57%
24333217052

push

github

web-flow 
Support multi-client and all-clients skill installation (#4732)

* Support multiple clients per skill install

Add InstallOptions.Clients, resolve and validate client paths, multi-dir
extract/write with rollback, and legacy empty-Clients digest no-op.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Use clients array on skill install request

Breaking: install body field client is replaced by clients []string.
Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Send clients array from skills HTTP client

Mirror API install body; include group on install request DTO.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Add --clients flag for skill install

Comma-separated values map to InstallOptions.Clients.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Document multi-client skill install

Update OpenAPI install schema and CLI/skill user references.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Refactor multi-client skill install for lint limits

Extract git and OCI install paths into smaller helpers, add
missingClients and removeSkillDirs, and fix import order in tests.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Wrap skill install --clients flag definition

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Regenerate OpenAPI and skill install CLI docs

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Add path-containment validation for resolved skill directories

* Add tests for multi-client rollback and error paths

* Add path-containment validation for resolved skill directories

* Add tests for review-identified multi-client bugs

Cover legacy no-op with explicit client, upgrade extracting to all
existing clients, and multi-client rollback and error paths.

* Add path-containment validation for resolved skill directories

Apply filepath.Clean at path resolution time and validate against
traversal segments before any filesystem operation.

* Sanitize skill directory paths at use site to satisfy CodeQL

Apply filepat... (continued)

212 of 287 new or added lines in 4 files covered. (73.87%)

15 existing lines in 4 files now uncovered.

56693 of 86430 relevant lines covered (65.59%)

62.1 hits per line

Uncovered Changes

Lines Coverage ∆ File
59
86.44
 -1.29% pkg/skills/skillsvc/skillsvc.go
16
25.0
 -12.5% cmd/thv/app/skill_install.go

Coverage Regressions

Lines Coverage ∆ File
6
76.15
 -5.5% pkg/secrets/keyring/keyctl_linux.go
5
86.44
 -1.29% pkg/skills/skillsvc/skillsvc.go
2
73.63
 -0.64% pkg/runner/config.go
2
82.29
 -0.21% pkg/vmcp/composer/workflow_engine.go
Jobs
ID Job ID Ran Files Coverage
1 24333217052.1 617
65.59
 GitHub Action Run
Source Files on build 24333217052