uber / ringpop-go / 1640

95%

push

travis-ci

Fix: Race conditions (#178)

* Lets fail CI without races passing

* do not return the pointer of the internal Member object from the Exported Member methode on Node

* fix races around stats measurement

* Extract all event emitting logic to the events package and embed an EventEmitter in applicable structs

* Update mocks

* Fix flappy forwarding test during race detector

* Fix race on writing clock.

* copy member instead of passing internal pointer around for MemberAt

* ignore test for now, has 3 races, needs review what is being tested

* replace timebased deadline with count based deadline in waitForPartitionHeal

* fix two flappy tests due to incarnation number mismatches

* reset the logger to nil (NoLogger) after every test

* set timeout to negative value to always time out.

* solve race when sending the membership as changes

* Fix race in RandomPingableMembers

* Fix TestFilterChangesFromSender due to wrong use of incarnation causing race

* add tests for event registrar and emitter.

* rework ListenerFunc to be a struct

* refactor waitForConvergence to limit number of iterations instead of time.

* rename utils file for tests to exclude it from compiling

* upgrade tchannel-go version

* move ListenerFunc to _test.go file to exclude form export

* Rephrase documentation for DeregisterListener to be better understandable.

* reserve capacity before copying old listeners

* initialize listeners list with correct size on DeregisterListener

* explain why events.EventRegistar is not embedded in the ringpop interface.

* Correct naming of Emitter in favor of Registar

* Use readlock when reading dummyStats value

* move test utilities to _test.go file to exclude them from the public interface

* Enable last test without race conditions.

* Remove race causing flappy test when validating events are propagated.

* Remove unused dummy listener

* rework the background execution o... (continued)

100 of 100 new or added lines in 6 files covered. (100.0%)

4098 of 4314 relevant lines covered (94.99%)

3.15 hits per line