openvax / topiary / 24316538253

90%

push

github

Polish DSL internals — v5.0.1 (#115)

Follow-ups from the v5.0.0 review; no user-visible behavior changes.

- DSLNode.child_nodes() — new abstract method returning direct children.
  Generic tree walkers (_collect_column_names, future AST rewriters) no
  longer need a per-node isinstance ladder.  Every composite node type
  implements it (BinOp, UnaryOp, NormExpr, SurvivalExpr, LogisticExpr,
  ClipExpr, AggExpr, Comparison, BoolOp); leaves inherit the default
  empty list from the base class.
- The scoped-field filter guard moves from four per-operator overrides
  on Field (__le__/__ge__/__lt__/__gt__) into a single check in
  Comparison.__init__.  Same error message, less surface area, and the
  check now fires regardless of which side of the comparison is the
  scoped Field.
- apply_filter defensively reindexes the evaluated Series to
  ctx.group_index before masking, so an index mismatch surfaces as
  NaN → False rather than as misaligned row selection.

New tests in test_dsl_roundtrip.py cover the generic child_nodes()
walker via _collect_column_names across arithmetic, comparison, and
boolean composites.

23 of 27 new or added lines in 3 files covered. (85.19%)

2589 of 2972 relevant lines covered (87.11%)

2.61 hits per line