24316433690

Committed 12 Apr 2026 09:07PM UTC coverage: 20.841% (-0.04%) from 20.879%

Build # 24316433690

Build Type

Pull #982

github

Committed by

web-flow

Commit Message

Merge 3c3ed2f6f into 4880531ce

Pull Request Pull Request #982: test: add executor edge case tests

Coverage Stats

1110 of 5326 relevant lines covered (20.84%)

7.74 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

44.55

/src/pass.cpp

// SPDX-FileCopyrightText: 2016 Anne Jan Brouwer
// SPDX-License-Identifier: GPL-3.0-or-later
#include "pass.h"
#include "gpgkeystate.h"
#include "helpers.h"
#include "qtpasssettings.h"
#include "util.h"
#include <QDir>
#include <QFileInfo>
#include <QProcess>
#include <QRandomGenerator>
#include <QRegularExpression>
#include <utility>

#ifdef QT_DEBUG
#include "debughelper.h"
#endif

using Enums::GIT_INIT;
using Enums::GIT_PULL;
using Enums::GIT_PUSH;
using Enums::GPG_GENKEYS;
using Enums::PASS_COPY;
using Enums::PASS_INIT;
using Enums::PASS_INSERT;
using Enums::PASS_MOVE;
using Enums::PASS_OTP_GENERATE;
using Enums::PASS_REMOVE;
using Enums::PASS_SHOW;

/**
 * @brief Pass::Pass wrapper for using either pass or the pass imitation
 */
Pass::Pass() : wrapperRunning(false), env(QProcess::systemEnvironment()) {
  connect(&exec,
          static_cast<void (Executor::*)(int, int, const QString &,
                                         const QString &)>(&Executor::finished),
          this, &Pass::finished);

  // This was previously using direct QProcess signals.
  // The code now uses Executor instead of raw QProcess for better control.
  // connect(&process, SIGNAL(error(QProcess::ProcessError)), this,
  //        SIGNAL(error(QProcess::ProcessError)));

  connect(&exec, &Executor::starting, this, &Pass::startingExecuteWrapper);
  env.append("WSLENV=PASSWORD_STORE_DIR/p");
}

/**
 * @brief Executes a wrapper command.
 * @param id Process ID
 * @param app Application to execute
 * @param args Arguments
 * @param readStdout Whether to read stdout
 * @param readStderr Whether to read stderr
 */
void Pass::executeWrapper(PROCESS id, const QString &app,
                          const QStringList &args, bool readStdout,
                          bool readStderr) {
  executeWrapper(id, app, args, QString(), readStdout, readStderr);
}

void Pass::executeWrapper(PROCESS id, const QString &app,
                          const QStringList &args, QString input,
                          bool readStdout, bool readStderr) {
#ifdef QT_DEBUG
  dbg() << app << args;
#endif
  exec.execute(id, QtPassSettings::getPassStore(), app, args, std::move(input),
               readStdout, readStderr);
}

/**
 * @brief Initializes the pass wrapper environment.
 */
void Pass::init() {
#ifdef __APPLE__
  // If it exists, add the gpgtools to PATH
  if (QFile("/usr/local/MacGPG2/bin").exists())
    env.replaceInStrings("PATH=", "PATH=/usr/local/MacGPG2/bin:");
  // Add missing /usr/local/bin
  if (env.filter("/usr/local/bin").isEmpty())
    env.replaceInStrings("PATH=", "PATH=/usr/local/bin:");
#endif

  if (!QtPassSettings::getGpgHome().isEmpty()) {
    QDir absHome(QtPassSettings::getGpgHome());
    absHome.makeAbsolute();
    env << "GNUPGHOME=" + absHome.path();
  }
}

/**
 * @brief Pass::Generate use either pwgen or internal password
 * generator
 * @param length of the desired password
 * @param charset to use for generation
 * @return the password
 */
auto Pass::generatePassword(unsigned int length, const QString &charset)
    -> QString {
  QString passwd;
  if (QtPassSettings::isUsePwgen()) {
    // --secure goes first as it overrides --no-* otherwise
    QStringList args;
    args.append("-1");
    if (!QtPassSettings::isLessRandom()) {
      args.append("--secure");
    }
    args.append(QtPassSettings::isAvoidCapitals() ? "--no-capitalize"
                                                  : "--capitalize");
    args.append(QtPassSettings::isAvoidNumbers() ? "--no-numerals"
                                                 : "--numerals");
    if (QtPassSettings::isUseSymbols()) {
      args.append("--symbols");
    }
    args.append(QString::number(length));
    // executeBlocking returns 0 on success, non-zero on failure
    if (Executor::executeBlocking(QtPassSettings::getPwgenExecutable(), args,
                                  &passwd) == 0) {
      static const QRegularExpression literalNewLines{"[\\n\\r]"};
      passwd.remove(literalNewLines);
    } else {
      passwd.clear();
#ifdef QT_DEBUG
      qDebug() << __FILE__ << ":" << __LINE__ << "\t"
               << "pwgen fail";
#endif
      // Error is already handled by clearing passwd; no need for critical
      // signal here
    }
  } else {
    // Validate charset - if CUSTOM is selected but chars are empty,
    // fall back to ALLCHARS to prevent weak passwords (issue #780)
    QString effectiveCharset = charset;
    if (effectiveCharset.isEmpty()) {
      effectiveCharset = QtPassSettings::getPasswordConfiguration()
                             .Characters[PasswordConfiguration::ALLCHARS];
    }
    if (effectiveCharset.length() > 0) {
      passwd = generateRandomPassword(effectiveCharset, length);
    } else {
      emit critical(
          tr("No characters chosen"),
          tr("Can't generate password, there are no characters to choose from "
             "set in the configuration!"));
    }
  }
  return passwd;
}

/**
 * @brief Pass::gpgSupportsEd25519 check if GPG supports ed25519 (ECC)
 * GPG 2.1+ supports ed25519 which is much faster for key generation
 * @return true if ed25519 is supported
 */
bool Pass::gpgSupportsEd25519() {
  QString out, err;
  if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(),
                                {"--version"}, &out, &err) != 0) {
    return false;
  }
  QRegularExpression versionRegex(R"(gpg \(GnuPG\) (\d+)\.(\d+))");
  QRegularExpressionMatch match = versionRegex.match(out);
  if (!match.hasMatch()) {
    return false;
  }
  int major = match.captured(1).toInt();
  int minor = match.captured(2).toInt();
  return major > 2 || (major == 2 && minor >= 1);
}

/**
 * @brief Pass::getDefaultKeyTemplate return default key generation template
 * Uses ed25519 if supported, otherwise falls back to RSA
 * @return GPG batch template string
 */
QString Pass::getDefaultKeyTemplate() {
  if (gpgSupportsEd25519()) {
    return QStringLiteral("%echo Generating a default key\n"
                          "Key-Type: EdDSA\n"
                          "Key-Curve: Ed25519\n"
                          "Subkey-Type: ECDH\n"
                          "Subkey-Curve: Curve25519\n"
                          "Name-Real: \n"
                          "Name-Comment: QtPass\n"
                          "Name-Email: \n"
                          "Expire-Date: 0\n"
                          "%no-protection\n"
                          "%commit\n"
                          "%echo done");
  }
  return QStringLiteral("%echo Generating a default key\n"
                        "Key-Type: RSA\n"
                        "Subkey-Type: RSA\n"
                        "Name-Real: \n"
                        "Name-Comment: QtPass\n"
                        "Name-Email: \n"
                        "Expire-Date: 0\n"
                        "%no-protection\n"
                        "%commit\n"
                        "%echo done");
}

namespace {
auto resolveWslGpgconfPath(const QString &lastPart) -> QString {
  int lastSep = lastPart.lastIndexOf('/');
  if (lastSep < 0) {
    lastSep = lastPart.lastIndexOf('\\');
  }
  if (lastSep >= 0) {
    return lastPart.left(lastSep + 1) + "gpgconf";
  }
  return QStringLiteral("gpgconf");
}

/**
 * @brief Finds the path to the gpgconf executable in the same directory as the
 * given GPG path.
 * @example
 * QString result = findGpgconfInGpgDir(gpgPath);
 * std::cout << result.toStdString() << std::endl; // Expected output: path to
 * gpgconf or empty string
 *
 * @param gpgPath - Absolute path to a GPG executable or related file used to
 * locate gpgconf.
 * @return QString - The full path to gpgconf if found and executable; otherwise
 * an empty QString.
 */
QString findGpgconfInGpgDir(const QString &gpgPath) {
  QFileInfo gpgInfo(gpgPath);
  if (!gpgInfo.isAbsolute()) {
    return QString();
  }

  QDir dir(gpgInfo.absolutePath());

#ifdef Q_OS_WIN
  QFileInfo candidateExe(dir.filePath("gpgconf.exe"));
  if (candidateExe.isExecutable()) {
    return candidateExe.filePath();
  }
#endif

  QFileInfo candidate(dir.filePath("gpgconf"));
  if (candidate.isExecutable()) {
    return candidate.filePath();
  }
  return QString();
}

#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
/**
 * @brief Splits a command string into arguments while respecting quotes and
 * escape characters.
 * @example
 * QStringList result = splitCommandCompat("cmd \"arg one\" 'arg two'
 * escaped\\ space");
 * // Expected output: ["cmd", "arg one", "arg two", "escaped space"]
 *
 * @param command - The input command string to split into individual arguments.
 * @return QStringList - A list of parsed command arguments.
 */
QStringList splitCommandCompat(const QString &command) {
  QStringList result;
  QString current;
  bool inSingleQuote = false;
  bool inDoubleQuote = false;
  bool escaping = false;
  for (QChar ch : command) {
    if (escaping) {
      current.append(ch);
      escaping = false;
      continue;
    }
    if (ch == '\\') {
      escaping = true;
      continue;
    }
    if (ch == '\'' && !inDoubleQuote) {
      inSingleQuote = !inSingleQuote;
      continue;
    }
    if (ch == '"' && !inSingleQuote) {
      inDoubleQuote = !inDoubleQuote;
      continue;
    }
    if (ch.isSpace() && !inSingleQuote && !inDoubleQuote) {
      if (!current.isEmpty()) {
        result.append(current);
        current.clear();
      }
      continue;
    }
    current.append(ch);
  }
  if (escaping) {
    current.append('\\');
  }
  if (!current.isEmpty()) {
    result.append(current);
  }
  return result;
}
#endif

} // namespace

/**
 * @brief Resolves the appropriate gpgconf command from a given GPG executable
 * path or command string.
 * @example
 * ResolvedGpgconfCommand result = Pass::resolveGpgconfCommand("wsl.exe
 * /usr/bin/gpg"); std::cout << result.first.toStdString() << std::endl; //
 * Expected output sample
 *
 * @param const QString &gpgPath - Path or command string pointing to the GPG
 * executable.
 * @return ResolvedGpgconfCommand - A pair containing the resolved gpgconf
 * command and its arguments.
 */
auto Pass::resolveGpgconfCommand(const QString &gpgPath)
    -> ResolvedGpgconfCommand {
  if (gpgPath.trimmed().isEmpty()) {
    return {"gpgconf", {}};
  }

#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
  QStringList parts = QProcess::splitCommand(gpgPath);
#else
  QStringList parts = splitCommandCompat(gpgPath);
#endif

  if (parts.isEmpty()) {
    return {"gpgconf", {}};
  }

  const QString first = parts.first();
  if (first == "wsl" || first == "wsl.exe") {
    if (parts.size() >= 2 && parts.at(1).startsWith("sh")) {
      return {"gpgconf", {}};
    }
    if (parts.size() >= 2 &&
        QFileInfo(parts.last()).fileName().startsWith("gpg")) {
      QString wslGpgconf = resolveWslGpgconfPath(parts.last());
      parts.removeLast();
      parts.append(wslGpgconf);
      return {parts.first(), parts.mid(1)};
    }
    return {"gpgconf", {}};
  }

  if (!first.contains('/') && !first.contains('\\')) {
    return {"gpgconf", {}};
  }

  QString gpgconfPath = findGpgconfInGpgDir(gpgPath);
  if (!gpgconfPath.isEmpty()) {
    return {gpgconfPath, {}};
  }

  return {"gpgconf", {}};
}

/**
 * @brief Pass::GenerateGPGKeys internal gpg keypair generator . .
 * @param batch GnuPG style configuration string
 */
void Pass::GenerateGPGKeys(QString batch) {
  // Kill any stale GPG agents that might be holding locks on the key database
  // This helps avoid "database locked" timeouts during key generation
  QString gpgPath = QtPassSettings::getGpgExecutable();
  if (!gpgPath.isEmpty()) {
    ResolvedGpgconfCommand gpgconf = resolveGpgconfCommand(gpgPath);
    QStringList killArgs = gpgconf.arguments;
    killArgs << "--kill";
    killArgs << "gpg-agent";
    // Use same environment as key generation to target correct gpg-agent
    Executor::executeBlocking(env, gpgconf.program, killArgs);
  }

  executeWrapper(GPG_GENKEYS, gpgPath, {"--gen-key", "--no-tty", "--batch"},
                 std::move(batch));
}

/**
 * @brief Pass::listKeys list users
 * @param keystrings
 * @param secret list private keys
 * @return QList<UserInfo> users
 */
auto Pass::listKeys(QStringList keystrings, bool secret) -> QList<UserInfo> {
  QStringList args = {"--no-tty", "--with-colons", "--with-fingerprint"};
  args.append(secret ? "--list-secret-keys" : "--list-keys");

  for (const QString &keystring : AS_CONST(keystrings)) {
    if (!keystring.isEmpty()) {
      args.append(keystring);
    }
  }
  QString p_out;
  if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(), args,
                                &p_out) != 0) {
    return QList<UserInfo>();
  }
  return parseGpgColonOutput(p_out, secret);
}

/**
 * @brief Pass::listKeys list users
 * @param keystring
 * @param secret list private keys
 * @return QList<UserInfo> users
 */
auto Pass::listKeys(const QString &keystring, bool secret) -> QList<UserInfo> {
  return listKeys(QStringList(keystring), secret);
}

/**
 * @brief Pass::processFinished reemits specific signal based on what process
 * has finished
 * @param id    id of Pass process that was scheduled and finished
 * @param exitCode  return code of a process
 * @param out   output generated by process(if capturing was requested, empty
 *              otherwise)
 * @param err   error output generated by process(if capturing was requested,
 *              or error occurred)
 */
void Pass::finished(int id, int exitCode, const QString &out,
                    const QString &err) {
  auto pid = static_cast<PROCESS>(id);
  if (exitCode != 0) {
    emit processErrorExit(exitCode, err);
    return;
  }
  switch (pid) {
  case GIT_INIT:
    emit finishedGitInit(out, err);
    break;
  case GIT_PULL:
    emit finishedGitPull(out, err);
    break;
  case GIT_PUSH:
    emit finishedGitPush(out, err);
    break;
  case PASS_SHOW:
    emit finishedShow(out);
    break;
  case PASS_OTP_GENERATE:
    emit finishedOtpGenerate(out);
    break;
  case PASS_INSERT:
    emit finishedInsert(out, err);
    break;
  case PASS_REMOVE:
    emit finishedRemove(out, err);
    break;
  case PASS_INIT:
    emit finishedInit(out, err);
    break;
  case PASS_MOVE:
    emit finishedMove(out, err);
    break;
  case PASS_COPY:
    emit finishedCopy(out, err);
    break;
  case GPG_GENKEYS:
    emit finishedGenerateGPGKeys(out, err);
    break;
  default:
#ifdef QT_DEBUG
    dbg() << "Unhandled process type" << pid;
#endif
    break;
  }
}

/**
 * @brief Pass::updateEnv update the execution environment (used when
 * switching profiles)
 */
void Pass::updateEnv() {
  // put PASSWORD_STORE_SIGNING_KEY in env
  QStringList envSigningKey = env.filter("PASSWORD_STORE_SIGNING_KEY=");
  QString currentSigningKey = QtPassSettings::getPassSigningKey();
  if (envSigningKey.isEmpty()) {
    if (!currentSigningKey.isEmpty()) {
      // dbg()<< "Added
      // PASSWORD_STORE_SIGNING_KEY with" + currentSigningKey;
      env.append("PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);
    }
  } else {
    if (currentSigningKey.isEmpty()) {
      env.removeAll(envSigningKey.first());
    } else {
      // dbg()<< "Update
      // PASSWORD_STORE_SIGNING_KEY with " + currentSigningKey;
      env.replaceInStrings(envSigningKey.first(),
                           "PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);
    }
  }
  // put PASSWORD_STORE_DIR in env
  QStringList store = env.filter("PASSWORD_STORE_DIR=");
  if (store.isEmpty()) {
    env.append("PASSWORD_STORE_DIR=" + QtPassSettings::getPassStore());
  } else {
    // dbg()<< "Update
    // PASSWORD_STORE_DIR with " + passStore;
    env.replaceInStrings(store.first(), "PASSWORD_STORE_DIR=" +
                                            QtPassSettings::getPassStore());
  }
  exec.setEnvironment(env);
}

/**
 * @brief Pass::getGpgIdPath return gpgid file path for some file (folder).
 * @param for_file which file (folder) would you like the gpgid file path for.
 * @return path to the gpgid file.
 */
auto Pass::getGpgIdPath(const QString &for_file) -> QString {
  QString passStore =
      QDir::fromNativeSeparators(QtPassSettings::getPassStore());
  QString normalizedFile = QDir::fromNativeSeparators(for_file);
  QString fullPath = normalizedFile.startsWith(passStore)
                         ? normalizedFile
                         : passStore + "/" + normalizedFile;
  QDir gpgIdDir(QFileInfo(fullPath).absoluteDir());
  bool found = false;
  while (gpgIdDir.exists() && gpgIdDir.absolutePath().startsWith(passStore)) {
    if (QFile(gpgIdDir.absoluteFilePath(".gpg-id")).exists()) {
      found = true;
      break;
    }
    if (!gpgIdDir.cdUp()) {
      break;
    }
  }
  QString gpgIdPath(
      found ? gpgIdDir.absoluteFilePath(".gpg-id")
            : QDir(QtPassSettings::getPassStore()).filePath(".gpg-id"));

  return gpgIdPath;
}

/**
 * @brief Pass::getRecipientList return list of gpg-id's to encrypt for
 * @param for_file which file (folder) would you like recipients for
 * @return recipients gpg-id contents
 */
auto Pass::getRecipientList(const QString &for_file) -> QStringList {
  QFile gpgId(getGpgIdPath(for_file));
  if (!gpgId.open(QIODevice::ReadOnly | QIODevice::Text)) {
    return {};
  }
  QStringList recipients;
  while (!gpgId.atEnd()) {
    QString recipient(gpgId.readLine());
    recipient = recipient.split("#")[0].trimmed();
    if (!recipient.isEmpty()) {
      recipients += recipient;
    }
  }
  return recipients;
}

/**
 * @brief Pass::getRecipientString formatted string for use with GPG
 * @param for_file which file (folder) would you like recipients for
 * @param separator formating separator eg: " -r "
 * @param count
 * @return recipient string
 */
auto Pass::getRecipientString(const QString &for_file, const QString &separator,
                              int *count) -> QStringList {
  Q_UNUSED(separator)
  QStringList recipients = Pass::getRecipientList(for_file);
  if (count) {
    *count = recipients.size();
  }
  return recipients;
}

/* Copyright (C) 2017 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
 */

/**
 * @brief Generates a random number bounded by the given value.
 * @param bound Upper bound (exclusive)
 * @return Random number in range [0, bound)
 */
auto Pass::boundedRandom(quint32 bound) -> quint32 {
  if (bound < 2) {
    return 0;
  }

  quint32 randval;
  // Rejection-sampling threshold to avoid modulo bias:
  // In quint32 arithmetic, (1 + ~bound) wraps to (2^32 - bound), so
  // (1 + ~bound) % bound == 2^32 % bound.
  // Values randval < max_mod_bound are rejected; accepted values produce a
  // uniform distribution when reduced with (randval % bound).
  const quint32 max_mod_bound = (1 + ~bound) % bound;

  do {
    randval = QRandomGenerator::system()->generate();
  } while (randval < max_mod_bound);

  return randval % bound;
}

/**
 * @brief Generates a random password from the given charset.
 * @param charset Characters to use in the password
 * @param length Desired password length
 * @return Generated password string
 */
auto Pass::generateRandomPassword(const QString &charset, unsigned int length)
    -> QString {
  if (charset.isEmpty() || length == 0U) {
    return {};
  }
  QString out;
  for (unsigned int i = 0; i < length; ++i) {
    out.append(charset.at(static_cast<int>(
        boundedRandom(static_cast<quint32>(charset.length())))));
  }
  return out;
}

1	// SPDX-FileCopyrightText: 2016 Anne Jan Brouwer
2	// SPDX-License-Identifier: GPL-3.0-or-later
3	#include "pass.h"
4	#include "gpgkeystate.h"
5	#include "helpers.h"
6	#include "qtpasssettings.h"
7	#include "util.h"
8	#include <QDir>
9	#include <QFileInfo>
10	#include <QProcess>
11	#include <QRandomGenerator>
12	#include <QRegularExpression>
13	#include <utility>
14
15	#ifdef QT_DEBUG
16	#include "debughelper.h"
17	#endif
18
19	using Enums::GIT_INIT;
20	using Enums::GIT_PULL;
21	using Enums::GIT_PUSH;
22	using Enums::GPG_GENKEYS;
23	using Enums::PASS_COPY;
24	using Enums::PASS_INIT;
25	using Enums::PASS_INSERT;
26	using Enums::PASS_MOVE;
27	using Enums::PASS_OTP_GENERATE;
28	using Enums::PASS_REMOVE;
29	using Enums::PASS_SHOW;
30
31	/**
32	* @brief Pass::Pass wrapper for using either pass or the pass imitation
33	*/
34	Pass::Pass() : wrapperRunning(false), env(QProcess::systemEnvironment()) {	9✔
35	connect(&exec,	9✔
36	static_cast<void (Executor::*)(int, int, const QString &,
37	const QString &)>(&Executor::finished),
38	this, &Pass::finished);	9✔
39
40	// This was previously using direct QProcess signals.
41	// The code now uses Executor instead of raw QProcess for better control.
42	// connect(&process, SIGNAL(error(QProcess::ProcessError)), this,
43	// SIGNAL(error(QProcess::ProcessError)));
44
45	connect(&exec, &Executor::starting, this, &Pass::startingExecuteWrapper);	9✔
46	env.append("WSLENV=PASSWORD_STORE_DIR/p");	9✔
47	}	9✔
48
49	/**
50	* @brief Executes a wrapper command.
51	* @param id Process ID
52	* @param app Application to execute
53	* @param args Arguments
54	* @param readStdout Whether to read stdout
55	* @param readStderr Whether to read stderr
56	*/
57	void Pass::executeWrapper(PROCESS id, const QString &app,	×
58	const QStringList &args, bool readStdout,
59	bool readStderr) {
60	executeWrapper(id, app, args, QString(), readStdout, readStderr);	×
61	}	×
62
63	void Pass::executeWrapper(PROCESS id, const QString &app,	×
64	const QStringList &args, QString input,
65	bool readStdout, bool readStderr) {
66	#ifdef QT_DEBUG
67	dbg() << app << args;
68	#endif
69	exec.execute(id, QtPassSettings::getPassStore(), app, args, std::move(input),	×
70	readStdout, readStderr);
71	}	×
72
73	/**
74	* @brief Initializes the pass wrapper environment.
75	*/
76	void Pass::init() {	1✔
77	#ifdef __APPLE__
78	// If it exists, add the gpgtools to PATH
79	if (QFile("/usr/local/MacGPG2/bin").exists())
80	env.replaceInStrings("PATH=", "PATH=/usr/local/MacGPG2/bin:");
81	// Add missing /usr/local/bin
82	if (env.filter("/usr/local/bin").isEmpty())
83	env.replaceInStrings("PATH=", "PATH=/usr/local/bin:");
84	#endif
85
86	if (!QtPassSettings::getGpgHome().isEmpty()) {	2✔
87	QDir absHome(QtPassSettings::getGpgHome());	×
88	absHome.makeAbsolute();	×
89	env << "GNUPGHOME=" + absHome.path();	×
90	}	×
91	}	1✔
92
93	/**
94	* @brief Pass::Generate use either pwgen or internal password
95	* generator
96	* @param length of the desired password
97	* @param charset to use for generation
98	* @return the password
99	*/
100	auto Pass::generatePassword(unsigned int length, const QString &charset)	1,004✔
101	-> QString {
102	QString passwd;	1,004✔
103	if (QtPassSettings::isUsePwgen()) {	1,004✔
104	// --secure goes first as it overrides --no-* otherwise
105	QStringList args;	×
106	args.append("-1");	×
107	if (!QtPassSettings::isLessRandom()) {	×
108	args.append("--secure");	×
109	}
110	args.append(QtPassSettings::isAvoidCapitals() ? "--no-capitalize"	×
111	: "--capitalize");
112	args.append(QtPassSettings::isAvoidNumbers() ? "--no-numerals"	×
113	: "--numerals");
114	if (QtPassSettings::isUseSymbols()) {	×
115	args.append("--symbols");	×
116	}
117	args.append(QString::number(length));	×
118	// executeBlocking returns 0 on success, non-zero on failure
119	if (Executor::executeBlocking(QtPassSettings::getPwgenExecutable(), args,	×
120	&passwd) == 0) {
121	static const QRegularExpression literalNewLines{"[\\n\\r]"};	×
122	passwd.remove(literalNewLines);	×
123	} else {
124	passwd.clear();	×
125	#ifdef QT_DEBUG
126	qDebug() << __FILE__ << ":" << __LINE__ << "\t"
127	<< "pwgen fail";
128	#endif
129	// Error is already handled by clearing passwd; no need for critical
130	// signal here
131	}
132	} else {
133	// Validate charset - if CUSTOM is selected but chars are empty,
134	// fall back to ALLCHARS to prevent weak passwords (issue #780)
135	QString effectiveCharset = charset;
136	if (effectiveCharset.isEmpty()) {	1,004✔
137	effectiveCharset = QtPassSettings::getPasswordConfiguration()	2✔
138	.Characters[PasswordConfiguration::ALLCHARS];
139	}
140	if (effectiveCharset.length() > 0) {	1,004✔
141	passwd = generateRandomPassword(effectiveCharset, length);	2,008✔
142	} else {
143	emit critical(	×
144	tr("No characters chosen"),	×
145	tr("Can't generate password, there are no characters to choose from "	×
146	"set in the configuration!"));
147	}
148	}
149	return passwd;	1,004✔
150	}
151
152	/**
153	* @brief Pass::gpgSupportsEd25519 check if GPG supports ed25519 (ECC)
154	* GPG 2.1+ supports ed25519 which is much faster for key generation
155	* @return true if ed25519 is supported
156	*/
157	bool Pass::gpgSupportsEd25519() {	1✔
158	QString out, err;	1✔
159	if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(),	4✔
160	{"--version"}, &out, &err) != 0) {
161	return false;
162	}
163	QRegularExpression versionRegex(R"(gpg \(GnuPG\) (\d+)\.(\d+))");	×
164	QRegularExpressionMatch match = versionRegex.match(out);	×
165	if (!match.hasMatch()) {	×
166	return false;
167	}
168	int major = match.captured(1).toInt();	×
169	int minor = match.captured(2).toInt();	×
170	return major > 2 \|\| (major == 2 && minor >= 1);	×
171	}	1✔
172
173	/**
174	* @brief Pass::getDefaultKeyTemplate return default key generation template
175	* Uses ed25519 if supported, otherwise falls back to RSA
176	* @return GPG batch template string
177	*/
178	QString Pass::getDefaultKeyTemplate() {	1✔
179	if (gpgSupportsEd25519()) {	1✔
180	return QStringLiteral("%echo Generating a default key\n"	×
181	"Key-Type: EdDSA\n"
182	"Key-Curve: Ed25519\n"
183	"Subkey-Type: ECDH\n"
184	"Subkey-Curve: Curve25519\n"
185	"Name-Real: \n"
186	"Name-Comment: QtPass\n"
187	"Name-Email: \n"
188	"Expire-Date: 0\n"
189	"%no-protection\n"
190	"%commit\n"
191	"%echo done");
192	}
193	return QStringLiteral("%echo Generating a default key\n"	1✔
194	"Key-Type: RSA\n"
195	"Subkey-Type: RSA\n"
196	"Name-Real: \n"
197	"Name-Comment: QtPass\n"
198	"Name-Email: \n"
199	"Expire-Date: 0\n"
200	"%no-protection\n"
201	"%commit\n"
202	"%echo done");
203	}
204
205	namespace {
206	auto resolveWslGpgconfPath(const QString &lastPart) -> QString {	3✔
207	int lastSep = lastPart.lastIndexOf('/');	3✔
208	if (lastSep < 0) {	3✔
209	lastSep = lastPart.lastIndexOf('\\');	2✔
210	}
211	if (lastSep >= 0) {	2✔
212	return lastPart.left(lastSep + 1) + "gpgconf";	2✔
213	}
214	return QStringLiteral("gpgconf");	2✔
215	}
216
217	/**
218	* @brief Finds the path to the gpgconf executable in the same directory as the
219	* given GPG path.
220	* @example
221	* QString result = findGpgconfInGpgDir(gpgPath);
222	* std::cout << result.toStdString() << std::endl; // Expected output: path to
223	* gpgconf or empty string
224	*
225	* @param gpgPath - Absolute path to a GPG executable or related file used to
226	* locate gpgconf.
227	* @return QString - The full path to gpgconf if found and executable; otherwise
228	* an empty QString.
229	*/
230	QString findGpgconfInGpgDir(const QString &gpgPath) {	1✔
231	QFileInfo gpgInfo(gpgPath);	1✔
232	if (!gpgInfo.isAbsolute()) {	1✔
233	return QString();
234	}
235
236	QDir dir(gpgInfo.absolutePath());	1✔
237
238	#ifdef Q_OS_WIN
239	QFileInfo candidateExe(dir.filePath("gpgconf.exe"));
240	if (candidateExe.isExecutable()) {
241	return candidateExe.filePath();
242	}
243	#endif
244
245	QFileInfo candidate(dir.filePath("gpgconf"));	1✔
246	if (candidate.isExecutable()) {	1✔
247	return candidate.filePath();	×
248	}
249	return QString();
250	}	1✔
251
252	#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
253	/**
254	* @brief Splits a command string into arguments while respecting quotes and
255	* escape characters.
256	* @example
257	* QStringList result = splitCommandCompat("cmd \"arg one\" 'arg two'
258	* escaped\\ space");
259	* // Expected output: ["cmd", "arg one", "arg two", "escaped space"]
260	*
261	* @param command - The input command string to split into individual arguments.
262	* @return QStringList - A list of parsed command arguments.
263	*/
264	QStringList splitCommandCompat(const QString &command) {
265	QStringList result;
266	QString current;
267	bool inSingleQuote = false;
268	bool inDoubleQuote = false;
269	bool escaping = false;
270	for (QChar ch : command) {
271	if (escaping) {
272	current.append(ch);
273	escaping = false;
274	continue;
275	}
276	if (ch == '\\') {
277	escaping = true;
278	continue;
279	}
280	if (ch == '\'' && !inDoubleQuote) {
281	inSingleQuote = !inSingleQuote;
282	continue;
283	}
284	if (ch == '"' && !inSingleQuote) {
285	inDoubleQuote = !inDoubleQuote;
286	continue;
287	}
288	if (ch.isSpace() && !inSingleQuote && !inDoubleQuote) {
289	if (!current.isEmpty()) {
290	result.append(current);
291	current.clear();
292	}
293	continue;
294	}
295	current.append(ch);
296	}
297	if (escaping) {
298	current.append('\\');
299	}
300	if (!current.isEmpty()) {
301	result.append(current);
302	}
303	return result;
304	}
305	#endif
306
307	} // namespace
308
309	/**
310	* @brief Resolves the appropriate gpgconf command from a given GPG executable
311	* path or command string.
312	* @example
313	* ResolvedGpgconfCommand result = Pass::resolveGpgconfCommand("wsl.exe
314	* /usr/bin/gpg"); std::cout << result.first.toStdString() << std::endl; //
315	* Expected output sample
316	*
317	* @param const QString &gpgPath - Path or command string pointing to the GPG
318	* executable.
319	* @return ResolvedGpgconfCommand - A pair containing the resolved gpgconf
320	* command and its arguments.
321	*/
322	auto Pass::resolveGpgconfCommand(const QString &gpgPath)	8✔
323	-> ResolvedGpgconfCommand {
324	if (gpgPath.trimmed().isEmpty()) {	8✔
325	return {"gpgconf", {}};
326	}
327
328	#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
329	QStringList parts = QProcess::splitCommand(gpgPath);	7✔
330	#else
331	QStringList parts = splitCommandCompat(gpgPath);
332	#endif
333
334	if (parts.isEmpty()) {	7✔
335	return {"gpgconf", {}};
336	}
337
338	const QString first = parts.first();
339	if (first == "wsl" \|\| first == "wsl.exe") {	9✔
340	if (parts.size() >= 2 && parts.at(1).startsWith("sh")) {	9✔
341	return {"gpgconf", {}};
342	}
343	if (parts.size() >= 2 &&	4✔
344	QFileInfo(parts.last()).fileName().startsWith("gpg")) {	10✔
345	QString wslGpgconf = resolveWslGpgconfPath(parts.last());	3✔
346	parts.removeLast();	3✔
347	parts.append(wslGpgconf);
348	return {parts.first(), parts.mid(1)};
349	}
350	return {"gpgconf", {}};
351	}
352
353	if (!first.contains('/') && !first.contains('\\')) {	2✔
354	return {"gpgconf", {}};
355	}
356
357	QString gpgconfPath = findGpgconfInGpgDir(gpgPath);	1✔
358	if (!gpgconfPath.isEmpty()) {	1✔
359	return {gpgconfPath, {}};	×
360	}
361
362	return {"gpgconf", {}};
363	}	8✔
364
365	/**
366	* @brief Pass::GenerateGPGKeys internal gpg keypair generator . .
367	* @param batch GnuPG style configuration string
368	*/
369	void Pass::GenerateGPGKeys(QString batch) {	×
370	// Kill any stale GPG agents that might be holding locks on the key database
371	// This helps avoid "database locked" timeouts during key generation
372	QString gpgPath = QtPassSettings::getGpgExecutable();	×
373	if (!gpgPath.isEmpty()) {	×
374	ResolvedGpgconfCommand gpgconf = resolveGpgconfCommand(gpgPath);	×
375	QStringList killArgs = gpgconf.arguments;
376	killArgs << "--kill";	×
377	killArgs << "gpg-agent";	×
378	// Use same environment as key generation to target correct gpg-agent
379	Executor::executeBlocking(env, gpgconf.program, killArgs);	×
380	}
381
382	executeWrapper(GPG_GENKEYS, gpgPath, {"--gen-key", "--no-tty", "--batch"},	×
383	std::move(batch));
384	}	×
385
386	/**
387	* @brief Pass::listKeys list users
388	* @param keystrings
389	* @param secret list private keys
390	* @return QList<UserInfo> users
391	*/
392	auto Pass::listKeys(QStringList keystrings, bool secret) -> QList<UserInfo> {	×
393	QStringList args = {"--no-tty", "--with-colons", "--with-fingerprint"};	×
394	args.append(secret ? "--list-secret-keys" : "--list-keys");	×
395
396	for (const QString &keystring : AS_CONST(keystrings)) {	×
397	if (!keystring.isEmpty()) {	×
398	args.append(keystring);
399	}
400	}
401	QString p_out;	×
402	if (Executor::executeBlocking(QtPassSettings::getGpgExecutable(), args,	×
403	&p_out) != 0) {
404	return QList<UserInfo>();	×
405	}
406	return parseGpgColonOutput(p_out, secret);	×
407	}	×
408
409	/**
410	* @brief Pass::listKeys list users
411	* @param keystring
412	* @param secret list private keys
413	* @return QList<UserInfo> users
414	*/
415	auto Pass::listKeys(const QString &keystring, bool secret) -> QList<UserInfo> {	×
416	return listKeys(QStringList(keystring), secret);	×
417	}
418
419	/**
420	* @brief Pass::processFinished reemits specific signal based on what process
421	* has finished
422	* @param id id of Pass process that was scheduled and finished
423	* @param exitCode return code of a process
424	* @param out output generated by process(if capturing was requested, empty
425	* otherwise)
426	* @param err error output generated by process(if capturing was requested,
427	* or error occurred)
428	*/
429	void Pass::finished(int id, int exitCode, const QString &out,	×
430	const QString &err) {
431	auto pid = static_cast<PROCESS>(id);
432	if (exitCode != 0) {	×
433	emit processErrorExit(exitCode, err);	×
434	return;	×
435	}
436	switch (pid) {	×
437	case GIT_INIT:	×
438	emit finishedGitInit(out, err);	×
439	break;	×
440	case GIT_PULL:	×
441	emit finishedGitPull(out, err);	×
442	break;	×
443	case GIT_PUSH:	×
444	emit finishedGitPush(out, err);	×
445	break;	×
446	case PASS_SHOW:	×
447	emit finishedShow(out);	×
448	break;	×
449	case PASS_OTP_GENERATE:	×
450	emit finishedOtpGenerate(out);	×
451	break;	×
452	case PASS_INSERT:	×
453	emit finishedInsert(out, err);	×
454	break;	×
455	case PASS_REMOVE:	×
456	emit finishedRemove(out, err);	×
457	break;	×
458	case PASS_INIT:	×
459	emit finishedInit(out, err);	×
460	break;	×
461	case PASS_MOVE:	×
462	emit finishedMove(out, err);	×
463	break;	×
464	case PASS_COPY:	×
465	emit finishedCopy(out, err);	×
466	break;	×
467	case GPG_GENKEYS:	×
468	emit finishedGenerateGPGKeys(out, err);	×
469	break;	×
470	default:
471	#ifdef QT_DEBUG
472	dbg() << "Unhandled process type" << pid;
473	#endif
474	break;
475	}
476	}
477
478	/**
479	* @brief Pass::updateEnv update the execution environment (used when
480	* switching profiles)
481	*/
482	void Pass::updateEnv() {	×
483	// put PASSWORD_STORE_SIGNING_KEY in env
484	QStringList envSigningKey = env.filter("PASSWORD_STORE_SIGNING_KEY=");	×
485	QString currentSigningKey = QtPassSettings::getPassSigningKey();	×
486	if (envSigningKey.isEmpty()) {	×
487	if (!currentSigningKey.isEmpty()) {	×
488	// dbg()<< "Added
489	// PASSWORD_STORE_SIGNING_KEY with" + currentSigningKey;
490	env.append("PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);	×
491	}
492	} else {
493	if (currentSigningKey.isEmpty()) {	×
494	env.removeAll(envSigningKey.first());
495	} else {
496	// dbg()<< "Update
497	// PASSWORD_STORE_SIGNING_KEY with " + currentSigningKey;
498	env.replaceInStrings(envSigningKey.first(),	×
499	"PASSWORD_STORE_SIGNING_KEY=" + currentSigningKey);	×
500	}
501	}
502	// put PASSWORD_STORE_DIR in env
503	QStringList store = env.filter("PASSWORD_STORE_DIR=");	×
504	if (store.isEmpty()) {	×
505	env.append("PASSWORD_STORE_DIR=" + QtPassSettings::getPassStore());	×
506	} else {
507	// dbg()<< "Update
508	// PASSWORD_STORE_DIR with " + passStore;
509	env.replaceInStrings(store.first(), "PASSWORD_STORE_DIR=" +	×
510	QtPassSettings::getPassStore());	×
511	}
512	exec.setEnvironment(env);	×
513	}	×
514
515	/**
516	* @brief Pass::getGpgIdPath return gpgid file path for some file (folder).
517	* @param for_file which file (folder) would you like the gpgid file path for.
518	* @return path to the gpgid file.
519	*/
520	auto Pass::getGpgIdPath(const QString &for_file) -> QString {	8✔
521	QString passStore =
522	QDir::fromNativeSeparators(QtPassSettings::getPassStore());	16✔
523	QString normalizedFile = QDir::fromNativeSeparators(for_file);	8✔
524	QString fullPath = normalizedFile.startsWith(passStore)	8✔
525	? normalizedFile	8✔
526	: passStore + "/" + normalizedFile;	6✔
527	QDir gpgIdDir(QFileInfo(fullPath).absoluteDir());	8✔
528	bool found = false;
529	while (gpgIdDir.exists() && gpgIdDir.absolutePath().startsWith(passStore)) {	10✔
530	if (QFile(gpgIdDir.absoluteFilePath(".gpg-id")).exists()) {	2✔
531	found = true;
532	break;
533	}
534	if (!gpgIdDir.cdUp()) {	×
535	break;
536	}
537	}
538	QString gpgIdPath(
539	found ? gpgIdDir.absoluteFilePath(".gpg-id")	8✔
540	: QDir(QtPassSettings::getPassStore()).filePath(".gpg-id"));	29✔
541
542	return gpgIdPath;	8✔
543	}	8✔
544
545	/**
546	* @brief Pass::getRecipientList return list of gpg-id's to encrypt for
547	* @param for_file which file (folder) would you like recipients for
548	* @return recipients gpg-id contents
549	*/
550	auto Pass::getRecipientList(const QString &for_file) -> QStringList {	5✔
551	QFile gpgId(getGpgIdPath(for_file));	5✔
552	if (!gpgId.open(QIODevice::ReadOnly \| QIODevice::Text)) {	5✔
553	return {};	×
554	}
555	QStringList recipients;	5✔
556	while (!gpgId.atEnd()) {	14✔
557	QString recipient(gpgId.readLine());	18✔
558	recipient = recipient.split("#")[0].trimmed();	18✔
559	if (!recipient.isEmpty()) {	9✔
560	recipients += recipient;
561	}
562	}
563	return recipients;
564	}	5✔
565
566	/**
567	* @brief Pass::getRecipientString formatted string for use with GPG
568	* @param for_file which file (folder) would you like recipients for
569	* @param separator formating separator eg: " -r "
570	* @param count
571	* @return recipient string
572	*/
573	auto Pass::getRecipientString(const QString &for_file, const QString &separator,	2✔
574	int *count) -> QStringList {
575	Q_UNUSED(separator)
576	QStringList recipients = Pass::getRecipientList(for_file);	2✔
577	if (count) {	2✔
578	*count = recipients.size();	1✔
579	}
580	return recipients;	2✔
581	}
582
583	/* Copyright (C) 2017 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
584	*/
585
586	/**
587	* @brief Generates a random number bounded by the given value.
588	* @param bound Upper bound (exclusive)
589	* @return Random number in range [0, bound)
590	*/
591	auto Pass::boundedRandom(quint32 bound) -> quint32 {	1,160✔
592	if (bound < 2) {	1,160✔
593	return 0;
594	}
595
596	quint32 randval;
597	// Rejection-sampling threshold to avoid modulo bias:
598	// In quint32 arithmetic, (1 + ~bound) wraps to (2^32 - bound), so
599	// (1 + ~bound) % bound == 2^32 % bound.
600	// Values randval < max_mod_bound are rejected; accepted values produce a
601	// uniform distribution when reduced with (randval % bound).
602	const quint32 max_mod_bound = (1 + ~bound) % bound;	1,160✔
603
604	do {
605	randval = QRandomGenerator::system()->generate();
606	} while (randval < max_mod_bound);	1,160✔
607
608	return randval % bound;	1,160✔
609	}
610
611	/**
612	* @brief Generates a random password from the given charset.
613	* @param charset Characters to use in the password
614	* @param length Desired password length
615	* @return Generated password string
616	*/
617	auto Pass::generateRandomPassword(const QString &charset, unsigned int length)	1,004✔
618	-> QString {
619	if (charset.isEmpty() \|\| length == 0U) {	1,004✔
620	return {};
621	}
622	QString out;	1,003✔
623	for (unsigned int i = 0; i < length; ++i) {	2,163✔
624	out.append(charset.at(static_cast<int>(	1,160✔
625	boundedRandom(static_cast<quint32>(charset.length())))));	1,160✔
626	}
627	return out;
628	}

IJHack / QtPass / 24316433690

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous