archetech / archon / 24313762204

95%

main: 89%

Pull #404

github

Clear Rust gatekeeper compiler and clippy warnings

Library (6 warnings):
- rename CheckDidsResult fields to snake_case (by_type/by_registry/
  by_version/events_queue) and rely on existing #[serde(rename = "…")]
  attributes for wire-format parity with TS
- drop the never-read service_version_info field from Metrics; the
  metric is still registered via the cloned handle passed to
  registry.register(...)
- gate the check_dids_impl re-export behind #[cfg(test)] since it is
  only used from tests

Tests (~30 dead-code warnings):
- add #![allow(dead_code)] at the top of tests/common/mod.rs so the
  shared helper module doesn't emit a warning per binary for helpers
  that only some integration tests call

Clippy:
- items.iter().cloned().collect() -> items.to_vec()
- std::io::Error::new(ErrorKind::Other, ...) -> std::io::Error::other(...)
- value.len() % 2 != 0 -> !value.len().is_multiple_of(2)
- &[second.clone()] -> std::slice::from_ref(&second)
- drop unnecessary borrows in redis_compat.rs redis calls

cargo build --all-targets and cargo clippy --all-targets now both emit
zero warnings. All 38 tests still pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

1990 of 2192 branches covered (90.78%)

Branch coverage included in aggregate %.

4231 of 4345 relevant lines covered (97.38%)

1167.51 hits per line