c-ares / c-ares / 24307329566

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix microsecond overflow in ares_queue_wait_empty timeout (#1122)

When computing the deadline in ares_queue_wait_empty(), the
millisecond-to-microsecond addition could cause tout.usec to exceed
1,000,000 if ares_tvnow() returned a non-zero usec component. This
corrupted the ares_timeval_remaining() comparison, causing premature
timeouts.

Extract the static timeadd() from ares_process.c into a shared
ares_timeval_add() utility in ares_timeout.c (alongside the existing
ares_timeval_remaining and ares_timeval_diff), and use it in both
ares_process.c and ares_threads.c.

Signed-off-by: David Hotham (@dimbleby)

Coverage Stats

9 of 10 new or added lines in 3 files covered. (90.0%)

2 existing lines in 2 files now uncovered.

22779 of 24843 relevant lines covered (91.69%)

12872.76 hits per line