c-ares / c-ares / 24307008388

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix malloc(0) in ares_htable_all_buckets on empty table (#1131)

When num_keys is 0, ares_malloc_zero(0) is called. On platforms where
malloc(0) returns non-NULL, both callers leak the pointer since they
check for NULL-or-empty and return without freeing. On platforms where
malloc(0) returns NULL, callers cannot distinguish empty from OOM.
Return NULL early when the table is empty.

Signed-off-by: David Hotham (@dimbleby)

Coverage Stats

1 of 2 new or added lines in 1 file covered. (50.0%)

1 existing line in 1 file now uncovered.

22769 of 24835 relevant lines covered (91.68%)

12887.04 hits per line