GEWIS / sudosos-backend / 24289911115

92%

push

github

refactor: switch SQLite driver from sqlite3 to better-sqlite3 (#876)

- Replace `sqlite3` with `better-sqlite3@12.8.0` in dependencies
- Remove `'sqlite'` connection type entirely — `better-sqlite3` is
  the only supported SQLite driver going forward
- Update `pnpm.onlyBuiltDependencies` accordingly
- `DatabaseConnection` type and `VALID_DATABASE_CONNECTIONS` now only
  list `better-sqlite3` (alongside mariadb/mysql/postgres)
- `isSqlite` is simply `databaseConnection === 'better-sqlite3'`
- Update `getBootstrapDataSourceOptions()` in `database.ts` to use
  `better-sqlite3`
- Update `test/setup.ts` defaults, `test/unit/database.ts` skip
  guard, and `test/helpers/test-helpers.ts` drop condition to use
  `better-sqlite3`
- Update CI matrix and coverage condition to `better-sqlite3`
- Fix two raw-SQL queries in `balance-service.ts` that used
  double-quoted string literals (`"VALUE"`) — `better-sqlite3`
  enforces the SQL standard strictly (double quotes = identifiers,
  single quotes = strings); `sqlite3` silently fell back

Closes #728

1826 of 2247 branches covered (81.26%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

9406 of 10364 relevant lines covered (90.76%)

1014.86 hits per line