DanielXMoore / Civet / 24287283766

95%

push

github

Convert LSP source and build to Civet (#1935)

### LSP source converted from TypeScript to Civet

All LSP source files have been rewritten from `.mts` TypeScript to `.civet`:

- `server.mts` → `server.civet`
- `lib/typescript-service.mts` → `lib/typescript-service.civet`
- `lib/util.mts` → `lib/util.civet`
- `lib/previewer.mts` → `lib/previewer.civet`
- `lib/textRendering.mts` → `lib/textRendering.civet`

### E2E test suite added

New end-to-end tests that spin up a real VS Code instance via `@vscode/test-electron` and exercise the LSP over the language client protocol:

- `e2e/completion.test.civet` — completion items
- `e2e/at-completions.test.civet` — `@`-prefixed decorator completions
- `e2e/definition.test.civet` — go-to-definition
- `e2e/hover.test.civet` — hover info
- `e2e/diagnostics.test.civet` — error diagnostics
- `e2e/document-symbols.test.civet` — document symbol outline
- `e2e/references.test.civet` — find references
- `e2e/fixture/` — shared Civet fixture files used by the tests

### Unit test coverage expanded

- `test/service.civet` — significantly expanded TypeScript service tests
- `test/rendering.civet` — new rendering/hover text tests
- `test/util-extra.civet` — new utility function tests
- `lsp/scripts/show-uncovered.mjs` — script for visualizing uncovered code regions

### CI workflow added

`.github/workflows/lsp.yml` — new GitHub Actions workflow that runs `pnpm build && pnpm test && pnpm e2e` in the `lsp/` directory on every push or PR touching `lsp/**`. Builds the root `@danielx/civet` package first so the LSP build can find the `civet` binary.

### Build fix

`lsp/build/build.sh` was updated to use `${CIVET_BIN:-../dist/civet}` instead of a hardcoded `node_modules/.bin/civet` path, which pnpm does not create for workspace-linked packages in CI.

### esbuild pinned to 0.27.5

`pnpm.overrides.esbuild` pinned back to `0.27.5` (from `^0.27.0`) to avoid a regression in esbuild 0.27.7 that breaks the VitePress docs build with a ... (continued)

4235 of 4619 branches covered (91.69%)

Branch coverage included in aggregate %.

20316 of 21129 relevant lines covered (96.15%)

46682.77 hits per line