mroderick / codebar-planner / 24286558792

96%

master: 96%

push

github

fix(test): freeze time in tests to prevent flaky failures

Remove timecop gem dependency and use Rails' travel_to helper.

Time-based scopes compare against Time.zone.now evaluated at query time,
while test fixtures used relative times evaluated at creation time. This
caused flaky tests when any time passed between fixture creation and query.

Files changed:
- Remove timecop from Gemfile and test.rb config
- Add travel_to blocks to time-dependent tests in shared examples,
  listable_spec, attendance_warning_spec, feature tests, rake tasks,
  and presenter specs

Fixes flaky test failures in CI runs.

4 of 4 new or added lines in 1 file covered. (100.0%)

3483 of 3645 relevant lines covered (95.56%)

46.12 hits per line