mroderick / codebar-planner / 24286005864

96%

master: 96%

push

github

fix(test): freeze time in tests to prevent flaky failures

Remove timecop gem and standardize on ActiveSupport time helpers.

- Remove timecop from Gemfile and test.rb config
- Migrate Timecop.travel to travel_to in listable_spec.rb
- Fix shared_examples/behaves_like_an_invitation.rb by wrapping
  time-dependent tests in travel_to blocks
- Add time freezing to #completed_since_yesterday, #next, #most_recent
  tests that compare against Time.zone.now

The scopes upcoming_rsvps and taken_place compare date_and_time
against Time.zone.now evaluated at query time, while test fixtures
used relative times like 2.days.ago evaluated at creation time.
Freezing time ensures both are evaluated relative to the same moment.

Fixes flaky test failures in PR #2538 CI runs.

4 of 4 new or added lines in 1 file covered. (100.0%)

3483 of 3645 relevant lines covered (95.56%)

46.09 hits per line