GEWIS / sudosos-backend / 24280021673

92%

push

github

refactor: lift ProductController validators into AsyncValidatorMiddleware (#842)

Migrates CreateProductRequest and UpdateProductRequest from inline
isFail checks to the globalAsyncValidatorRegistry pattern introduced
in #834, completing the remaining items from issue #116.

- Replace verifyCreateProductRequest / verifyProductRequest with
  createProductRequestSpecFactory / updateProductRequestSpecFactory
- Register both specs in the ProductController constructor with
  buildTarget lambdas that reconstruct CreateProductParams (ownerId
  defaulting to token user) and UpdateProductParams (id from route param)
- Remove isFail blocks from createProduct and updateProduct handlers
- Update test assertions from bare string equality to the standardised
  { valid: false, errors[] } shape returned

1825 of 2247 branches covered (81.22%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 2 files covered. (100.0%)

9406 of 10364 relevant lines covered (90.76%)

1014.83 hits per line