umputun / revdiff / 24277629943

88%

master: 90%

Build Type

Pull #92

github

Committed by umputun

Commit Message

fix(style): address Copilot review findings on PR #92

Apply four fixes from Copilot's PR review:

1. FileStatusMark color leak (renderer.go): when Colors.Normal is
   unset, the status color had no terminating ANSI sequence and
   bled into subsequent text on the same line. Fall back to ResetFg
   ("\033[39m") when normalFg is empty. Added regression test
   TestRenderer_FileStatusMark_emptyNormalFallsBackToResetFg.

2. FileReviewedMark color leak (renderer.go): same bug pattern as
   FileStatusMark — AddFg checkmark color would bleed when Normal
   was empty. Same fix. Added regression subtest
   emptyNormalFallsBackToResetFg.

3. Pin go-pkgz/enum generator version (enums.go): the go:generate
   directives used @latest, making regeneration non-reproducible.
   Pinned to @v0.7.0 matching the version in go.mod. Verified
   regeneration produces identical output.

4. Drop tautological NotNil assertion (resolver_test.go): the
   TestResolver_Style_coversAllKeys test asserted require.NotNil on
   lipgloss.Style return values, but lipgloss.Style is a struct
   value type that can never be nil. The assertion always passed.
   Replaced with `_ = r.Style(k)` to match the sibling
   TestResolver_Color_coversAllKeys pattern — the exhaustiveness
   check's real purpose is "no panic for any defined key", not a
   nil check.

Pull Request Pull Request #92: refactor(ui): extract style sub-package with Resolver/Renderer/SGR

Coverage Stats

880 of 996 new or added lines in 19 files covered. (88.35%)

1 existing line in 1 file now uncovered.

6066 of 6862 relevant lines covered (88.4%)

382.9 hits per line