chrisns / repomanager / 24274349063

85%

master: 85%

Pull #1555

github

Neutralise hyphens in consent-issue marker ids (CodeQL js/bad-tag-filter)

The original encodeId only rewrote literal `-->` and left the equally-valid
HTML5 comment end `--!>` (and bare `--`) untouched. CodeQL flagged this.

Percent-encode the id with encodeURIComponent and additionally swap `-` for
`%2D` so no hyphen pair can appear inside the embedded `<!-- repomanager:... -->`
comment at all. Parsers decode the id back on the way out.

Regression test fuzzes several hyphenated ids and asserts every emitted
HTML comment interior is free of `--`.

Also:
- ignore `.aws-sam/` in jest testPathIgnorePatterns and .gitignore so the
  SAM build artifact directory isn't treated as a duplicate test tree

126 of 178 branches covered (70.79%)

Branch coverage included in aggregate %.

338 of 370 new or added lines in 6 files covered. (91.35%)

341 of 374 relevant lines covered (91.18%)

7.82 hits per line