stacklok / toolhive / 24265416574

66%

Build Type

push

github

Committed by web-flow

Commit Message

Fix GetDefaultProvider bypassing registered config factory (#4740)

* Fix GetDefaultProvider bypassing registered config factory

config.NewDefaultProvider() skips the RegisterProviderFactory hook and
always reads the local XDG config file. Switch to config.NewProvider(),
which checks the registered factory first and falls back to the default
only when no factory is registered.

Without this fix, enterprise builds that register a factory to supply an
EnterpriseProvider (e.g. fetching config from a remote config server)
were silently ignored, causing thv registry commands to use the embedded
registry instead of the configured one.

Add unit tests covering the factory-respected and fall-through cases,
caching semantics, and reset behaviour.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix NewRegistryRoutes constructors bypassing registered config factory

Both NewRegistryRoutes and NewRegistryRoutesForServe called
config.NewDefaultProvider(), which skips the RegisterProviderFactory
hook and always reads the local XDG config file. Switch to
config.NewProvider() so enterprise builds that register a factory
(e.g. to supply a remote config server) are correctly honoured.

Add unit tests covering the regression case and the no-factory fallback
for both constructors.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Move config.NewProvider() inside sync.Once closure in GetDefaultProvider

Go evaluates function arguments eagerly, so the previous implementation
called config.NewProvider() (and thus any registered ProviderFactory)
on every invocation of GetDefaultProvider, even after sync.Once had
already fired and the resulting provider was discarded.

Move the call inside the Do closure so the factory is invoked at most
once. GetDefaultProvider now owns its sync.Once block directly rather
than delegating to GetDefaultProviderWithConfig.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix data race between ResetDefault... (continued)

Coverage Stats

16 of 20 new or added lines in 2 files covered. (80.0%)

6 existing lines in 2 files now uncovered.

56387 of 86073 relevant lines covered (65.51%)

62.64 hits per line