tarantool / tarantool / 24243164933

88%

Build Type

push

github

Committed by locker

Commit Message

box: remove tuple dictionary from space definition

When we made the tuple format registry thread-local in commit
8c3a20d74a59a ("box: make tuple format registry thread-local"),
we assumed that it's safe to pass a space definition object to
another thread in order to create a thread-local copy of a tuple
format for a Vinyl dump/compaction task. Turns out it isn't true
because a space definition stores a reference to a tuple dictionary,
which is passed to `tuple_format_new()`, which increments its
reference counter, which is obviously not a thread-safe operation.

Actually, we don't really need to store a tuple dictionary in
a space definition because it's used only for rollback of a space
format update. Instead of storing the dictionary in a space definition,
we can store it in the DDL operation itself. This change makes
a space definition a trivial object, as it should be, safe to be
passed from one thread to another.

Note that this patch makes `space_def_new()` non-failing so it also
removes the code checking its return value.

The bug was found by Andrey Saranchin (@drewdzzz) with TSAN.

Follow-up #12210

NO_DOC=bug fix
NO_CHANGELOG=unreleased
NO_TEST=difficult to catch; should be checked by TSAN

Coverage Stats

70670 of 118923 branches covered (59.43%)

23 of 23 new or added lines in 4 files covered. (100.0%)

25 existing lines in 7 files now uncovered.

106287 of 121220 relevant lines covered (87.68%)

1353603.19 hits per line