stacklok / toolhive / 24242575708

66%

Build Type

push

github

Committed by web-flow

Commit Message

Return registry type on error for accurate user-facing messages (#4733)

* Return registry type on error for accurate user-facing messages

SetRegistryFromInput was returning an empty string for the registry type
on error paths, which produced broken error messages like
"The  at https://..." with a blank where the type should appear. Now
the detected type is always returned so enhanceRegistryError can
include it. Also adds a hint that the remote URL must return JSON.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Guard URL-specific hints for non-file registries, fix default case return

Address review comments:
- Only show "URL points to a valid MCP registry" and "remote URL returns
  valid JSON" hints when the registry type is not a local file
- Return registryType instead of "" in the default switch case for
  consistency with other error paths

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

2 of 15 new or added lines in 2 files covered. (13.33%)

11 existing lines in 3 files now uncovered.

56879 of 87252 relevant lines covered (65.19%)

62.32 hits per line