supabase / auth / 24239666854

69%

Build Type

push

github

Committed by web-flow

Commit Message

fix(passkeys): modify the passkeys request and response shapes (#2475)

Modifies some of the passkeys request/response shapes for a cleaner
interface and to better align with industry standards. In particular:

The `/options` endpoints removes unnecessary nesting (a byproduct of
serializing the go-webauthn object directly):

```
{
  "challenge_id": "some-challenge-id",
  "options": {
    "publicKey": {
      // ... the public key options
    },
  }
  "expires_at": 1234567890
}
```

becomes:

```
{
  "challenge_id": "some-challenge-id",
  "options": {
    // ... the public key options
  }
  "expires_at": 1234567890
}
```

---

Rename the `credential` in the `/verify` endpoint payload from
`credential_response` to `credential`:

```
{
  "challenge_id": "some-challenge-id",
  "credential_response": {
    // ... the response from the client
  }
}
```

becomes

```
{
  "challenge_id": "some-challenge-id",
  "credential": {
    // ... the response from the client
  }
}
```

---

Finally, remove the `backed_up`, `backup_eligible`, and `transports`
fields from the `/verify` response upon registration. We can later
expose them consistently across the API responses if/when needed.

Coverage Stats

10 of 11 new or added lines in 2 files covered. (90.91%)

1 existing line in 1 file now uncovered.

16628 of 23974 relevant lines covered (69.36%)

82.16 hits per line