KarpelesLab / anyhash / 24230317918

88%

Build Type

push

github

Committed by MagicalTux

Commit Message

Fix xxh128 seed, murmur3c/f PHP carry encoding, xxh32/64 validation

- xxh128: the 17..128-byte path used (len * PRIME64_2) when computing the
  high 64 bits, missing the seed term. Use (len - seed) * PRIME64_2 per the
  XXH3 reference so non-zero seeds produce correct high bits.

- murmur3c / murmur3f MarshalPHP: encode the carry buffer into 4 uint32s
  (PHP_MURMUR3C_SPEC "lllllllll") / 2 uint64s (PHP_MURMUR3F_SPEC "qqqql")
  using PHP's high-byte shift-in packing, with the carry length stored in
  the low byte of the last carry per pcarry[i] = (k & ~0xff) | n. The old
  single-uint32 packing lost bytes beyond position 3 and misplaced slots.

- xxh32 / xxh64 UnmarshalPHP: validate the buffer length up front and
  return an error instead of panicking on the next Write when the state
  carries an out-of-range n.

Cross-validated bidirectionally against PHP 8.2 for murmur3c/f at every
partial length 1..30 and for xxh128 with seeds 42/123 in the 17..128 range.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

78 of 0 new or added lines in 0 files covered. (NaN%)

107 existing lines in 2 files now uncovered.

2793 of 3210 relevant lines covered (87.01%)

1121.37 hits per line